Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom plugin to publish zips to maven #400

Conversation

martin-gaievski
Copy link
Member

Signed-off-by: Martin Gaievski gaievski@amazon.com

Description

Follow campaign and use custom plugin to publish zips to maven

Issues Resolved

#378

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@martin-gaievski martin-gaievski added Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. v2.0.0 backport 2.0 auto backport label labels May 18, 2022
@martin-gaievski martin-gaievski requested a review from a team May 18, 2022 19:13
settings.gradle Outdated Show resolved Hide resolved
scripts/build.sh Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
…pdate dev url

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@martin-gaievski
Copy link
Member Author

@prudhvigodithi I've made requested changes, could you please check one more time?

@prudhvigodithi
Copy link
Member

Hey @martin-gaievski
LGTM, please test to run build.sh on local to verify this works and able to publish the zip to local maven repo.
Thank you

@martin-gaievski
Copy link
Member Author

Hey @martin-gaievski LGTM, please test to run build.sh on local to verify this works and able to publish the zip to local maven repo. Thank you

Checked locally, I see fresh artifacts created, after running
./scripts/build.sh -v 2.0.0 -s true
here is the content of local repo:

[test@4c84b01b6a34 k-NN]$ ls artifacts/maven/org/opensearch/plugin/opensearch-knn/2.0.0.0-SNAPSHOT/ -la
total 3112
drwxrwxr-x 2 test test    4096 May 18 21:56 .
drwxrwxr-x 3 test test    4096 May 18 21:56 ..
-rw-rw-r-- 1 test test     791 May 18 21:56 maven-metadata.xml
-rw-rw-r-- 1 test test      32 May 18 21:56 maven-metadata.xml.md5
-rw-rw-r-- 1 test test      40 May 18 21:56 maven-metadata.xml.sha1
-rw-rw-r-- 1 test test      64 May 18 21:56 maven-metadata.xml.sha256
-rw-rw-r-- 1 test test     128 May 18 21:56 maven-metadata.xml.sha512
-rw-rw-r-- 1 test test     977 May 18 21:56 opensearch-knn-2.0.0.0-20220518.215628-1.pom
-rw-rw-r-- 1 test test      32 May 18 21:56 opensearch-knn-2.0.0.0-20220518.215628-1.pom.md5
-rw-rw-r-- 1 test test      40 May 18 21:56 opensearch-knn-2.0.0.0-20220518.215628-1.pom.sha1
-rw-rw-r-- 1 test test      64 May 18 21:56 opensearch-knn-2.0.0.0-20220518.215628-1.pom.sha256
-rw-rw-r-- 1 test test     128 May 18 21:56 opensearch-knn-2.0.0.0-20220518.215628-1.pom.sha512
-rw-rw-r-- 1 test test 3118876 May 18 21:56 opensearch-knn-2.0.0.0-20220518.215628-1.zip
-rw-rw-r-- 1 test test      32 May 18 21:56 opensearch-knn-2.0.0.0-20220518.215628-1.zip.md5
-rw-rw-r-- 1 test test      40 May 18 21:56 opensearch-knn-2.0.0.0-20220518.215628-1.zip.sha1
-rw-rw-r-- 1 test test      64 May 18 21:56 opensearch-knn-2.0.0.0-20220518.215628-1.zip.sha256
-rw-rw-r-- 1 test test     128 May 18 21:56 opensearch-knn-2.0.0.0-20220518.215628-1.zip.sha512

@martin-gaievski martin-gaievski merged commit f4c2d0f into opensearch-project:main May 18, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-400-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f4c2d0f20304f5a76a26afb0250b2a5cfce9a641
# Push it to GitHub
git push --set-upstream origin backport/backport-400-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-400-to-2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.0 auto backport label Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants