-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add groupId to pluginzip publication #578
Conversation
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Should we first fix the github workflow which was failing before we merge this PR? |
We have PR that fixes github workflow #577, but it needs this change in order to run BWC tests. It's a circular dependency here |
Signed-off-by: prudhvigodithi <pgodithi@amazon.com> (cherry picked from commit 82173fb)
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> (cherry picked from commit 82173fb)
Signed-off-by: prudhvigodithi pgodithi@amazon.com
Description
add groupId to pluginzip publication
Issues Resolved
#520
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.