Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add groupId to pluginzip publication #578

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Oct 12, 2022

Signed-off-by: prudhvigodithi pgodithi@amazon.com

Description

add groupId to pluginzip publication

Issues Resolved

#520

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@navneet1v
Copy link
Collaborator

Should we first fix the github workflow which was failing before we merge this PR?

@vamshin vamshin self-requested a review October 12, 2022 21:26
@martin-gaievski
Copy link
Member

Should we first fix the github workflow which was failing before we merge this PR?

We have PR that fixes github workflow #577, but it needs this change in order to run BWC tests. It's a circular dependency here

@martin-gaievski martin-gaievski merged commit 82173fb into opensearch-project:main Oct 13, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 13, 2022
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit 82173fb)
martin-gaievski pushed a commit to martin-gaievski/k-NN that referenced this pull request Oct 13, 2022
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
(cherry picked from commit 82173fb)
martin-gaievski pushed a commit that referenced this pull request Oct 13, 2022
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
(cherry picked from commit 82173fb)

Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
@heemin32 heemin32 added v2.4.0 'Issues and PRs related to version v2.4.0' and removed 2.4.0 labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants