Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Map, List, and Set in org.opensearch.common.collect with java.util references #816

Merged

Conversation

naveentatikonda
Copy link
Member

Description

Replace Map, List, and Set in org.opensearch.common.collect with java.util references

Issues Resolved

#815

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveentatikonda naveentatikonda added Refactoring Improve the design, structure, and implementation while preserving its functionality backport 2.x v2.7.0 labels Mar 23, 2023
@naveentatikonda naveentatikonda requested a review from a team March 23, 2023 04:18
vamshin
vamshin previously approved these changes Mar 23, 2023
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Merging #816 (0ff7750) into main (e1d2e45) will decrease coverage by 0.26%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #816      +/-   ##
============================================
- Coverage     85.40%   85.14%   -0.26%     
+ Complexity     1084     1079       -5     
============================================
  Files           151      151              
  Lines          4370     4370              
  Branches        390      390              
============================================
- Hits           3732     3721      -11     
- Misses          463      472       +9     
- Partials        175      177       +2     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

….util references

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@naveentatikonda naveentatikonda merged commit f6d3d40 into opensearch-project:main Mar 28, 2023
@naveentatikonda naveentatikonda deleted the refactor_set_package branch March 28, 2023 17:14
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 28, 2023
….util references (#816)

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit f6d3d40)
naveentatikonda added a commit that referenced this pull request Mar 29, 2023
….util references (#816) (#825)

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit f6d3d40)

Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Refactoring Improve the design, structure, and implementation while preserving its functionality v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants