feat: replace dash with em dash (#255) (#257)

Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit b817d98) Co-authored-by: Lin Wang <wonglam@amazon.com>
opensearch-project · Sep 1, 2023 · fe59e3c · fe59e3c
1 parent c2daa30
commit fe59e3c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/public/components/monitoring/model_deployment_table.tsx b/public/components/monitoring/model_deployment_table.tsx
@@ -97,7 +97,7 @@ export const ModelDeploymentTable = ({
         truncateText: true,
         textOnly: true,
         render: (_id: string, modelDeploymentItem: ModelDeploymentItem) => {
-          return modelDeploymentItem.connector?.name || '-';
+          return modelDeploymentItem.connector?.name || '\u2014';
         },
       },
       {
@@ -115,7 +115,7 @@ export const ModelDeploymentTable = ({
             respondingNodesCount === undefined ||
             notRespondingNodesCount === undefined
           ) {
-            return '-';
+            return '\u2014';
           }
           if (respondingNodesCount === 0) {
             return (

diff --git a/public/components/monitoring/tests/model_deployment_table.test.tsx b/public/components/monitoring/tests/model_deployment_table.test.tsx
@@ -137,8 +137,8 @@ describe('<DeployedModelTable />', () => {
       expect(within(header).getByText('Connector name')).toBeInTheDocument();
       expect(columnContent?.length).toBe(3);
       const cells = columnContent!;
-      expect(within(cells[0] as HTMLElement).getByText('-')).toBeInTheDocument();
-      expect(within(cells[1] as HTMLElement).getByText('-')).toBeInTheDocument();
+      expect(within(cells[0] as HTMLElement).getByText('\u2014')).toBeInTheDocument();
+      expect(within(cells[1] as HTMLElement).getByText('\u2014')).toBeInTheDocument();
       expect(within(cells[2] as HTMLElement).getByText('Sagemaker')).toBeInTheDocument();
     });
 

diff --git a/public/components/preview_panel/__tests__/connector_details.test.tsx b/public/components/preview_panel/__tests__/connector_details.test.tsx
@@ -22,9 +22,9 @@ describe('<ConnectorDetails />', () => {
     expect(screen.getByText('Connector description')).toBeInTheDocument();
   });
 
-  it('should render - when id is empty', () => {
+  it('should render em dash when id is empty', () => {
     setup({ id: '' });
-    expect(screen.getByText('-')).toBeInTheDocument();
+    expect(screen.getByText('\u2014')).toBeInTheDocument();
     expect(screen.queryByTestId('copyable-text-div')).not.toBeInTheDocument();
   });
 

diff --git a/public/components/preview_panel/connector_details.tsx b/public/components/preview_panel/connector_details.tsx
@@ -28,23 +28,23 @@ export const ConnectorDetails = (props: { name?: string; id?: string; descriptio
         <EuiFlexGroup>
           <EuiFlexItem>
             <EuiDescriptionListTitle>Connector name</EuiDescriptionListTitle>
-            <EuiDescriptionListDescription>{name ? name : '-'}</EuiDescriptionListDescription>
+            <EuiDescriptionListDescription>{name ? name : '\u2014'}</EuiDescriptionListDescription>
           </EuiFlexItem>
           <EuiFlexItem>
             <EuiDescriptionListTitle>Connector ID</EuiDescriptionListTitle>
             <EuiDescriptionListDescription>
               {id ? (
                 <CopyableText text={id} iconLeft={false} tooltipText="Copy connector ID" />
               ) : (
-                '-'
+                '\u2014'
               )}
             </EuiDescriptionListDescription>
           </EuiFlexItem>
         </EuiFlexGroup>
         <EuiSpacer size="m" />
         <EuiDescriptionListTitle>Connector description</EuiDescriptionListTitle>
         <EuiDescriptionListDescription>
-          {description ? description : '-'}
+          {description ? description : '\u2014'}
         </EuiDescriptionListDescription>
       </EuiDescriptionList>
     </>