feat: display notification when upload model by URL #126
Conversation
| // 1. model id doesn't exist | ||
| // 2. the current task is running fine without error | ||
| if (!res.model_id && !res.error) { | ||
| this.tasks.next(this.tasks.getValue().set(options.taskId, observable)); |
There was a problem hiding this comment.
Could we append this tasks outside? From the code I think this setter will be called after first get task detail API response, it may cause race condition.
There was a problem hiding this comment.
Updated so that it only set the task once.
My intention was only adding the running task to this.task, if we know a task is completed or has error in the first call, then we don't add it to this.tasks. So that we can know the current running task count by subscribe to this.tasks.
Btw, what's the race condition you mentioned?
There was a problem hiding this comment.
I'm misunderstanding here. What I originally wanted to ask is that there is a time gap from the user calls the query method to the tasks add the task to the map. If you access the tasks map within this time gap, user won't get the corresponding task. Do we need to concern about this problem?
There was a problem hiding this comment.
this.tasks can be converted to observable, see this.getTasks$, user can subscribe to the observable to get the changes
There was a problem hiding this comment.
Sure. Is that means the changes notified after first get task detail API called? I think it's OK if these is intention.
There was a problem hiding this comment.
Yes, I was thinking of only pushing it to tasks when we know the task is in progress from the first API response. So this.tasks represents the tasks which are in progress.
public/components/register_model/__tests__/register_model_artifact.test.tsx
Show resolved
Hide resolved
refactor model upload hook by rxjs Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
refactor hook based model task polling function with rxjs Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
force-pushed
the
model-upload-by-url-notification
branch
from
4bdc07e to
a11907e
Compare
…ct#126) + polling model upload task status and show notifications if task failed/successful + removed useModelUpload hook and refactor it with rxjs --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Yulong Ruan ruanyl@amazon.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.