Feature/add model version loading empty error screens #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l version table Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
…on table Signed-off-by: Lin Wang <wonglam@amazon.com>
…d_time to model detail version status cell Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov Report
@@ Coverage Diff @@
## feature/model-registry #185 +/- ##
==========================================================
+ Coverage 83.01% 84.69% +1.68%
==========================================================
Files 104 108 +4
Lines 1943 2091 +148
Branches 396 448 +52
==========================================================
+ Hits 1613 1771 +158
+ Misses 244 234 -10
Partials 86 86 |
ruanyl
reviewed
May 23, 2023
public/components/model/model_versions_panel/model_version_table.tsx
Outdated
Show resolved
Hide resolved
public/components/model/model_versions_panel/model_version_status_detail.tsx
Outdated
Show resolved
Hide resolved
public/components/model/model_versions_panel/model_version_cell.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Lin Wang <wonglam@amazon.com>
ruanyl
reviewed
May 24, 2023
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
ruanyl
approved these changes
May 24, 2023
wanglam
added a commit
to wanglam/ml-commons-dashboards
that referenced
this pull request
Jan 3, 2025
…ject#185) * feat: add loading, empty, failed and no result screen for model detail version table Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add versionOrKeyword parameter for model search Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add search logic to model detail version table Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: update lastUpdated to lastUpdatedTime in model detail version table Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add last_registered_time, last_deployed_time and last_undeployed_time to model detail version status cell Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: only show 3 tag columns by default Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: change to use dateFormat in ui settings Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: hide time title for in progress version Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add sort to model detail version table Signed-off-by: Lin Wang <wonglam@amazon.com> * test: increase timeout to fix test case error in github runner Signed-off-by: Lin Wang <wonglam@amazon.com> * test: change to wait for version header exists Signed-off-by: Lin Wang <wonglam@amazon.com> * chore: address PR comments Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add UiSettingDateFormatTime Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: change to use UiSettingDateFormatTime Signed-off-by: Lin Wang <wonglam@amazon.com> * fix: model search sort validate with sort pair Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.