feat(ui): artifact and configuration edit #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
requested review from
wanglam and
raintygao
and removed request for
wanglam
Codecov Report
@@ Coverage Diff @@
## feature/model-registry #187 +/- ##
==========================================================
+ Coverage 83.29% 83.92% +0.63%
==========================================================
Files 105 107 +2
Lines 1987 2041 +54
Branches 413 430 +17
==========================================================
+ Hits 1655 1713 +58
+ Misses 244 240 -4
Partials 88 88 |
wanglam
reviewed
May 23, 2023
public/components/common/forms/__tests__/model_configuration/model_configuration.test.tsx
Outdated
Show resolved
Hide resolved
public/components/model_version/__tests__/version_artifact.test.tsx
Outdated
Show resolved
Hide resolved
| } | ||
| return true; | ||
| } | ||
| import { ModelConfiguration } from '../common/forms/model_configuration'; |
There was a problem hiding this comment.
Do we need to expose these form components and constants to common folder?
There was a problem hiding this comment.
You mean components like ModelConfiguration?
There was a problem hiding this comment.
I mean expose common/forms/model_configuration contents to common/forms/index.ts. Then we can use import {ModelConfiguration} from '../common' to import this component. That's not a big issue.
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
wanglam
approved these changes
May 23, 2023
wanglam
pushed a commit
to wanglam/ml-commons-dashboards
that referenced
this pull request
Jan 3, 2025
feat: edit model artifact and configuration on version details page Enable user to edit model version artifact and configuration --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds artifact and configuration to version details page
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.