Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jump to model detail page with correct #193

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented May 26, 2023

Description

  1. Speed up EuiDataGrid test cases
  2. Redirect to model detail page with correct model id

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

wanglam added 6 commits May 26, 2023 10:50
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #193 (1ef3415) into feature/model-registry (4161537) will increase coverage by 0.02%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##           feature/model-registry     #193      +/-   ##
==========================================================
+ Coverage                   85.35%   85.37%   +0.02%     
==========================================================
  Files                         110      110              
  Lines                        2151     2154       +3     
  Branches                      453      453              
==========================================================
+ Hits                         1836     1839       +3     
  Misses                        229      229              
  Partials                       86       86              

see 7 files with indirect coverage changes

@wanglam wanglam marked this pull request as ready for review May 26, 2023 05:52
@wanglam wanglam requested a review from ruanyl May 26, 2023 05:52
@wanglam wanglam merged commit 7b41f36 into opensearch-project:feature/model-registry May 26, 2023
wanglam added a commit to wanglam/ml-commons-dashboards that referenced this pull request Jan 3, 2025
* feat: mock EuiDataGrid to speedup case running

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add modelGroupId to model search

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: support modelGroupId search mock

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: mock EuiDataGrid to speedup model test

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: redirect to model page with correct model id

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update to use created_time

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants