Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compilation errors after changes in core #1184

Conversation

martin-gaievski
Copy link
Member

Description

Fix errors in main branch after recent core changes (core PR ref)

Issues Resolved

[List any issues this PR will resolve]

Check List

  • All tests pass
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@martin-gaievski martin-gaievski force-pushed the fix-compilation-errors-after-core-changes-3 branch from 4c96b9b to c03d910 Compare August 3, 2023 17:01
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1184 (c03d910) into main (2bd63bd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1184   +/-   ##
=========================================
  Coverage     84.12%   84.12%           
  Complexity     1755     1755           
=========================================
  Files           139      139           
  Lines          6716     6716           
  Branches        669      669           
=========================================
  Hits           5650     5650           
  Misses          769      769           
  Partials        297      297           
Flag Coverage Δ
ml-commons 84.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...main/java/org/opensearch/ml/task/MLTaskRunner.java 97.72% <ø> (ø)

Copy link
Collaborator

@jngz-es jngz-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ylwu-amzn ylwu-amzn merged commit 04e1dd6 into opensearch-project:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants