Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Changing messaging for ILlegalArgumentException on duplicate model gr… #1299

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a9687fc from #1294

#1294)

* Changing messaging for ILlegalArgumentException on duplicate model group creation.

Signed-off-by: Nate Boot <nateboot@amazon.com>

* Adjusting the test. `./gradlew test` passes.

Signed-off-by: Nate Boot <nateboot@amazon.com>

---------

Signed-off-by: Nate Boot <nateboot@amazon.com>
(cherry picked from commit a9687fc)
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env September 7, 2023 23:02 Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env September 7, 2023 23:02 Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env September 7, 2023 23:02 Inactive
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #1299 (6eb3ac0) into 2.x (99679bc) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #1299      +/-   ##
============================================
+ Coverage     79.36%   79.42%   +0.05%     
- Complexity     2246     2249       +3     
============================================
  Files           188      188              
  Lines          9074     9074              
  Branches        903      903              
============================================
+ Hits           7202     7207       +5     
+ Misses         1464     1458       -6     
- Partials        408      409       +1     
Flag Coverage Δ
ml-commons 79.42% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...a/org/opensearch/ml/model/MLModelGroupManager.java 83.62% <ø> (ø)

... and 2 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env September 7, 2023 23:25 Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env September 7, 2023 23:25 Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env September 7, 2023 23:25 Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env September 7, 2023 23:25 Inactive
@rbhavna rbhavna merged commit 979ac68 into 2.x Sep 8, 2023
7 of 9 checks passed
@github-actions github-actions bot deleted the backport/backport-1294-to-2.x branch September 8, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants