Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing doc link #1318

Merged
merged 2 commits into from
Sep 12, 2023
Merged

fixing doc link #1318

merged 2 commits into from
Sep 12, 2023

Conversation

dhrubo-os
Copy link
Collaborator

Description

[fixing doc link]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 11, 2023 20:51 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 11, 2023 20:51 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 11, 2023 20:51 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 11, 2023 20:51 — with GitHub Actions Inactive
@ylwu-amzn
Copy link
Collaborator

Thanks, can you also fix this doc https://github.com/opensearch-project/ml-commons/blob/main/docs/model_serving_framework/text_embedding_model_examples.md

# Sample request
POST /_plugins/_ml/models/_register
{
    "name": "huggingface/sentence-transformers/all-MiniLM-L12-v2",
    "version": "1.0.1",
    "model_format": "TORCH_SCRIPT"
    "model_group_id": "7IjOsYgBFp6IJxCceZ1-"
}

missing comma after "model_format": "TORCH_SCRIPT"

And indent issue for this part
Screenshot 2023-09-11 at 1 59 57 PM

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1318 (db9c0e7) into main (cd2604a) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1318      +/-   ##
============================================
+ Coverage     78.84%   78.90%   +0.05%     
- Complexity     2139     2142       +3     
============================================
  Files           168      168              
  Lines          8740     8740              
  Branches        877      877              
============================================
+ Hits           6891     6896       +5     
+ Misses         1450     1445       -5     
  Partials        399      399              
Flag Coverage Δ
ml-commons 78.90% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 11, 2023 21:10 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 11, 2023 21:10 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 11, 2023 21:10 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env September 11, 2023 21:10 — with GitHub Actions Inactive
@dhrubo-os
Copy link
Collaborator Author

Thanks, can you also fix this doc https://github.com/opensearch-project/ml-commons/blob/main/docs/model_serving_framework/text_embedding_model_examples.md

# Sample request
POST /_plugins/_ml/models/_register
{
    "name": "huggingface/sentence-transformers/all-MiniLM-L12-v2",
    "version": "1.0.1",
    "model_format": "TORCH_SCRIPT"
    "model_group_id": "7IjOsYgBFp6IJxCceZ1-"
}

missing comma after "model_format": "TORCH_SCRIPT"

And indent issue for this part Screenshot 2023-09-11 at 1 59 57 PM

Sure, fixed the indentation.

@dhrubo-os dhrubo-os merged commit a436169 into opensearch-project:main Sep 12, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2023
* fixing doc link

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing indentation

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
(cherry picked from commit a436169)
dhrubo-os added a commit that referenced this pull request Sep 12, 2023
* fixing doc link

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing indentation

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
(cherry picked from commit a436169)

Co-authored-by: Dhrubo Saha <dhrubo@amazon.com>
zane-neo added a commit that referenced this pull request Sep 26, 2023
* Add Auto Release Workflow (#1306)

* Add Auto Release Workflow

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Fix release note address

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

---------

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Bump aws-encryption-sdk-java to fix CVE-2023-33201 (#1309)

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Add release note for 2.10.0 release (#1312)

* Add release note for 2.10.0

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Add CVE fix

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

---------

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* fixing doc link (#1318)

* fixing doc link

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* fixing indentation

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* Fix unassigned ml system shard replicas (#1315) (#1324)

* Fix unassigned ml system shard replicas



* Adjust auto replica settings to keep it consistent with AOS default setting



* Update plugin/src/main/java/org/opensearch/ml/indices/MLIndicesHandler.java




* Modify exception handling



* Modify exception messages



* Add response check



* Add response check and exception handling



* Keep error message consistent



* Keep error message consistent



* Keep error message consistent



---------

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>

* Adjust index replicas settings to keep consistent with AOS 2.9 (#1325)

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Make 2.10 release notes up to date (#1345)

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* fix spelling (#1363)

Signed-off-by: Kalyan <kalyan.ben10@live.com>

* Add neural search default processor for non OpenAI/Cohere scenario (#1274)

* Add neural search default pre/post process function support

Signed-off-by: zane-neo <zaniu@amazon.com>

* Fix UT failures

Signed-off-by: zane-neo <zaniu@amazon.com>

* Address PR comment to remove nonJson response case

Signed-off-by: zane-neo <zaniu@amazon.com>

* Fix low code coverage issue

Signed-off-by: zane-neo <zaniu@amazon.com>

* fix format issue

Signed-off-by: zane-neo <zaniu@amazon.com>

* Try to fix classNotFound issue in IT

Signed-off-by: zane-neo <zaniu@amazon.com>

* revert Try to fix classNotFound issue in IT

Signed-off-by: zane-neo <zaniu@amazon.com>

* Change gson dependency to compileOnly

Signed-off-by: zane-neo <zaniu@amazon.com>

* Change default pre/post process function name

Signed-off-by: zane-neo <zaniu@amazon.com>

* Address code review comments

Signed-off-by: zane-neo <zaniu@amazon.com>

* Make preprocess function to default

Signed-off-by: zane-neo <zaniu@amazon.com>

* Remove GsonUtil since there already a single instance in StringUtils

Signed-off-by: zane-neo <zaniu@amazon.com>

* Fix UT failures

Signed-off-by: zane-neo <zaniu@amazon.com>

* Address comments

Signed-off-by: zane-neo <zaniu@amazon.com>

* use import instead of fully qualified name

Signed-off-by: zane-neo <zaniu@amazon.com>

---------

Signed-off-by: zane-neo <zaniu@amazon.com>

---------

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Kalyan <kalyan.ben10@live.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
Co-authored-by: Sicheng Song <sicheng.song@outlook.com>
Co-authored-by: Dhrubo Saha <dhrubo@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
Co-authored-by: Kalyan <kalyan.ben10@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants