adding model level metric in node level #1330

dhrubo-os · 2023-09-12T22:42:18Z

Description

[adding model level metric in node level : https://github.com//issues/1295

With this change stat api will show metrics like:

{
    "nodes": {
        "KKGb_PrDQl2zWWIhifyFdQ": {
            "algorithms": {
                "text_embedding": {
                    "deploy": {
                        "ml_action_request_count": 1
                    },
                    "register": {
                        "ml_action_request_count": 1
                    },
                    "predict": {
                        "ml_action_request_count": 1
                    }
                }
            },
            "models": {
                "FFt4i4oBkVwzPy8kRevJ": {
                    "deploy": {
                        "ml_action_request_count": 1
                    },
                    "predict": {
                        "ml_action_request_count": 1
                    }
                }
            }
        }
    }
}

]

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ylwu-amzn · 2023-09-13T00:38:32Z

CI failed

ylwu-amzn · 2023-10-04T01:13:12Z

plugin/src/main/java/org/opensearch/ml/stats/MLModelStats.java

+
+    @Override
+    public void writeTo(StreamOutput out) throws IOException {
+        if (modelStats != null && modelStats.size() > 0) {


Missed out.writeBoolean(true)? Also fix public MLModelStats(StreamInput in) ?

Sorry for the confusion. I didn't clearly understand your comment. This class is pretty much similar to this class

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* adding model level metric in node level Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * spotlessApply and fixed a test Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * added if clause to bypass the integration test Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressed comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * add more tests Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * adding boolean check if model stats exists Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit bb84282)

* adding model level metric in node level Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * spotlessApply and fixed a test Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * added if clause to bypass the integration test Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressed comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * add more tests Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * adding boolean check if model stats exists Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit bb84282) Co-authored-by: Dhrubo Saha <dhrubo@amazon.com>

…ensearch-project#1522) * adding model level metric in node level Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * spotlessApply and fixed a test Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * added if clause to bypass the integration test Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressed comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * add more tests Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * adding boolean check if model stats exists Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit bb84282) Co-authored-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: TrungBui59 <bui23@purdue.edu>

…ensearch-project#1522) * adding model level metric in node level Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * spotlessApply and fixed a test Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * added if clause to bypass the integration test Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressing comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * addressed comments Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * add more tests Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * adding boolean check if model stats exists Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> (cherry picked from commit bb84282) Co-authored-by: Dhrubo Saha <dhrubo@amazon.com>

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 22:42 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 22:42 — with GitHub Actions Error

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 22:42 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 22:42 — with GitHub Actions Error

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 22:59 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 22:59 — with GitHub Actions Error

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 23:00 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 23:00 — with GitHub Actions Error

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 23:24 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 23:24 — with GitHub Actions Error

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 23:24 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 23:41 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 23:41 — with GitHub Actions Error

dhrubo-os had a problem deploying to ml-commons-cicd-env September 12, 2023 23:41 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 13, 2023 00:18 — with GitHub Actions Error

dhrubo-os had a problem deploying to ml-commons-cicd-env September 13, 2023 00:18 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 13, 2023 00:18 — with GitHub Actions Error

dhrubo-os had a problem deploying to ml-commons-cicd-env September 13, 2023 00:52 — with GitHub Actions Error

dhrubo-os had a problem deploying to ml-commons-cicd-env September 13, 2023 00:52 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 13, 2023 00:52 — with GitHub Actions Error

dhrubo-os had a problem deploying to ml-commons-cicd-env September 13, 2023 01:08 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 13, 2023 01:08 — with GitHub Actions Error

dhrubo-os had a problem deploying to ml-commons-cicd-env September 13, 2023 01:08 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env September 13, 2023 01:26 — with GitHub Actions Error

dhrubo-os temporarily deployed to ml-commons-cicd-env October 4, 2023 00:32 — with GitHub Actions Inactive

dhrubo-os had a problem deploying to ml-commons-cicd-env October 4, 2023 00:32 — with GitHub Actions Failure

dhrubo-os temporarily deployed to ml-commons-cicd-env October 4, 2023 00:53 — with GitHub Actions Inactive

dhrubo-os had a problem deploying to ml-commons-cicd-env October 4, 2023 00:53 — with GitHub Actions Failure

dhrubo-os temporarily deployed to ml-commons-cicd-env October 4, 2023 00:53 — with GitHub Actions Inactive

ylwu-amzn reviewed Oct 4, 2023

View reviewed changes

adding boolean check if model stats exists

4abc1d1

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

dhrubo-os temporarily deployed to ml-commons-cicd-env October 4, 2023 19:58 — with GitHub Actions Inactive

dhrubo-os had a problem deploying to ml-commons-cicd-env October 4, 2023 19:58 — with GitHub Actions Failure

dhrubo-os had a problem deploying to ml-commons-cicd-env October 4, 2023 19:58 — with GitHub Actions Error

dhrubo-os temporarily deployed to ml-commons-cicd-env October 4, 2023 20:33 — with GitHub Actions Inactive

dhrubo-os had a problem deploying to ml-commons-cicd-env October 4, 2023 20:33 — with GitHub Actions Error

dhrubo-os temporarily deployed to ml-commons-cicd-env October 4, 2023 20:33 — with GitHub Actions Inactive

ylwu-amzn approved these changes Oct 4, 2023

View reviewed changes

dhrubo-os temporarily deployed to ml-commons-cicd-env October 4, 2023 20:57 — with GitHub Actions Inactive

jngz-es approved these changes Oct 4, 2023

View reviewed changes

dhrubo-os merged commit bb84282 into opensearch-project:2.x Oct 4, 2023
9 checks passed

ylwu-amzn added the backport main label Oct 16, 2023

opensearch-trigger-bot bot mentioned this pull request Oct 16, 2023

[Backport main] adding model level metric in node level #1522

Merged

dhrubo-os mentioned this pull request Nov 5, 2023

[FEATURE] Add model level stats #1295

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding model level metric in node level #1330

adding model level metric in node level #1330

dhrubo-os commented Sep 12, 2023 •

edited

Loading

ylwu-amzn commented Sep 13, 2023

ylwu-amzn Oct 4, 2023

dhrubo-os Oct 4, 2023

adding model level metric in node level #1330

adding model level metric in node level #1330

Conversation

dhrubo-os commented Sep 12, 2023 • edited Loading

Description

Issues Resolved

Check List

ylwu-amzn commented Sep 13, 2023

ylwu-amzn Oct 4, 2023

Choose a reason for hiding this comment

dhrubo-os Oct 4, 2023

Choose a reason for hiding this comment

dhrubo-os commented Sep 12, 2023 •

edited

Loading