Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 2.x] allow input null for text docs input (#1401) #1402

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

Backport #1401 to 2.x

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 17:02 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1402 (aa91556) into 2.x (5b59e3e) will increase coverage by 0.04%.
Report is 1 commits behind head on 2.x.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #1402      +/-   ##
============================================
+ Coverage     78.23%   78.28%   +0.04%     
- Complexity     2301     2304       +3     
============================================
  Files           195      195              
  Lines          9370     9370              
  Branches        917      917              
============================================
+ Hits           7331     7335       +4     
+ Misses         1624     1621       -3     
+ Partials        415      414       -1     
Flag Coverage Δ
ml-commons 78.28% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...h/ml/action/deploy/TransportDeployModelAction.java 64.97% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 17:25 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 17:25 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 17:50 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 17:50 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 17:50 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit aca02d1 into opensearch-project:2.x Sep 28, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants