Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix null exception in text docs data set #1403

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 03:25 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 03:25 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 03:25 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1403 (4f5b0a4) into main (358354c) will decrease coverage by 1.24%.
Report is 7 commits behind head on main.
The diff coverage is 57.98%.

@@             Coverage Diff              @@
##               main    #1403      +/-   ##
============================================
- Coverage     78.82%   77.58%   -1.24%     
- Complexity     2145     2180      +35     
============================================
  Files           168      173       +5     
  Lines          8755     8977     +222     
  Branches        878      889      +11     
============================================
+ Hits           6901     6965      +64     
- Misses         1455     1608     +153     
- Partials        399      404       +5     
Flag Coverage Δ
ml-commons 77.58% <57.98%> (-1.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rg/opensearch/ml/client/MachineLearningClient.java 100.00% <100.00%> (ø)
...earch/ml/engine/algorithms/TextEmbeddingModel.java 100.00% <100.00%> (ø)
...thms/sparse_encoding/SparseEncodingTranslator.java 100.00% <100.00%> (ø)
...rse_encoding/TextEmbeddingSparseEncodingModel.java 100.00% <100.00%> (ø)
...ing/HuggingfaceTextEmbeddingServingTranslator.java 100.00% <ø> (ø)
...NNXSentenceTransformerTextEmbeddingTranslator.java 67.04% <ø> (ø)
...ng/SentenceTransformerTextEmbeddingTranslator.java 100.00% <100.00%> (+2.38%) ⬆️
...rithms/text_embedding/TextEmbeddingDenseModel.java 91.30% <100.00%> (ø)
...va/org/opensearch/ml/engine/utils/ScriptUtils.java 90.00% <100.00%> (+13.52%) ⬆️
...tion/prediction/TransportPredictionTaskAction.java 78.26% <100.00%> (+0.48%) ⬆️
... and 10 more

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 05:20 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 05:20 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 05:20 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 28, 2023 05:20 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit cda89ff into opensearch-project:main Sep 28, 2023
7 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 28, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit cda89ff)
ylwu-amzn added a commit that referenced this pull request Sep 28, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit cda89ff)

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants