Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] 2.x consistent get interactions (#1334) #1432

Conversation

HenryL27
Copy link
Collaborator

@HenryL27 HenryL27 commented Oct 4, 2023

  • consistent getInteractions response when security/no security

  • fix deletion race condition

  • cleanup


(cherry picked from commit 24a629b)

Description

PR 3/4 to backport conversation features to main

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* consistent getInteractions response when security/no security

Signed-off-by: HenryL27 <hmlindeman@yahoo.com>

* fix deletion race condition

Signed-off-by: HenryL27 <hmlindeman@yahoo.com>

* cleanup

Signed-off-by: HenryL27 <hmlindeman@yahoo.com>

---------

Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
(cherry picked from commit 24a629b)
Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
@HenryL27 HenryL27 had a problem deploying to ml-commons-cicd-env October 4, 2023 20:47 — with GitHub Actions Failure
@HenryL27 HenryL27 temporarily deployed to ml-commons-cicd-env October 4, 2023 20:47 — with GitHub Actions Inactive
@HenryL27 HenryL27 temporarily deployed to ml-commons-cicd-env October 4, 2023 20:47 — with GitHub Actions Inactive
@HenryL27 HenryL27 temporarily deployed to ml-commons-cicd-env October 4, 2023 20:47 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os merged commit 663c15b into opensearch-project:main Oct 4, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants