Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport main] fix model group auto-deletion when last version is deleted #1523

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1f43b28 from #1444

* fix model group auto-deletion when last version is deleted

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
(cherry picked from commit 1f43b28)
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env October 16, 2023 23:20 Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env October 16, 2023 23:20 Inactive
@opensearch-trigger-bot opensearch-trigger-bot bot temporarily deployed to ml-commons-cicd-env October 16, 2023 23:20 Inactive
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #1523 (9885bf5) into main (701af31) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #1523      +/-   ##
============================================
- Coverage     78.40%   78.35%   -0.05%     
+ Complexity     2385     2376       -9     
============================================
  Files           195      195              
  Lines          9619     9588      -31     
  Branches        970      964       -6     
============================================
- Hits           7542     7513      -29     
  Misses         1637     1637              
+ Partials        440      438       -2     
Flag Coverage Δ
ml-commons 78.35% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...h/ml/action/models/DeleteModelTransportAction.java 82.75% <50.00%> (-1.14%) ⬇️

... and 1 file with indirect coverage changes

@ylwu-amzn ylwu-amzn merged commit 750a29c into main Oct 17, 2023
6 of 11 checks passed
@github-actions github-actions bot deleted the backport/backport-1444-to-main branch October 17, 2023 00:19
TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 21, 2023
…h-project#1444) (opensearch-project#1523)

* fix model group auto-deletion when last version is deleted

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
(cherry picked from commit 1f43b28)

Co-authored-by: Bhavana Ramaram <rbhavna@amazon.com>
Signed-off-by: TrungBui59 <bui23@purdue.edu>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
…h-project#1444) (opensearch-project#1523)

* fix model group auto-deletion when last version is deleted

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
(cherry picked from commit 1f43b28)

Co-authored-by: Bhavana Ramaram <rbhavna@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants