Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bedrock titan embedding model blueprint #1526

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
dhrubo-os
dhrubo-os previously approved these changes Oct 17, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 17, 2023 21:55 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 17, 2023 21:55 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 17, 2023 21:55 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 17, 2023 21:55 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 17, 2023 21:55 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 17, 2023 21:55 — with GitHub Actions Inactive
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 17, 2023 21:58 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 17, 2023 21:58 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1526 (4f9a1c4) into main (750a29c) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 4f9a1c4 differs from pull request most recent head 7bb9be7. Consider uploading reports for the commit 7bb9be7 to get more accurate results

@@             Coverage Diff              @@
##               main    #1526      +/-   ##
============================================
+ Coverage     78.37%   78.40%   +0.02%     
- Complexity     2376     2378       +2     
============================================
  Files           195      195              
  Lines          9588     9588              
  Branches        964      964              
============================================
+ Hits           7515     7517       +2     
+ Misses         1636     1633       -3     
- Partials        437      438       +1     
Flag Coverage Δ
ml-commons 78.40% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@ylwu-amzn ylwu-amzn added the documentation Improvements or additions to documentation label Oct 17, 2023
@ylwu-amzn ylwu-amzn merged commit e9e3834 into opensearch-project:main Oct 17, 2023
5 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 17, 2023
* add bedrock titan embedding model blueprint

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* fix create connector response

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* fix step number

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit e9e3834)
ylwu-amzn added a commit that referenced this pull request Oct 17, 2023
* add bedrock titan embedding model blueprint

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* fix create connector response

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* fix step number

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit e9e3834)

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 6, 2023
* add bedrock titan embedding model blueprint

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* fix create connector response

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* fix step number

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: TrungBui59 <bui23@purdue.edu>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Feb 29, 2024
* add bedrock titan embedding model blueprint

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* fix create connector response

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* fix step number

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x documentation Improvements or additions to documentation
Projects
Status: Planned work items
Development

Successfully merging this pull request may close these issues.

4 participants