Expose execute api for MLClient #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
jackiehanyang
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
wujunshen,
ylwu-amzn,
zane-neo and
Zhangxunmt
as code owners
jackiehanyang
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jackiehanyang
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jackiehanyang
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jackiehanyang
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jackiehanyang
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jackiehanyang
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
reviewed
Oct 23, 2023
|
|
||
| verify(client).execute(eq(MLExecuteTaskAction.INSTANCE), isA(MLExecuteTaskRequest.class), any()); | ||
| verify(executeTaskResponseActionListener).onResponse(argumentCaptor.capture()); | ||
| assertEquals(FunctionName.METRICS_CORRELATION, argumentCaptor.getValue().getFunctionName()); |
There was a problem hiding this comment.
can we assert the output too?
There was a problem hiding this comment.
I added this additional assert cause you can never have too many tests but test coverage of this file is already at 100% methods and 100% lines:)
Asserting anything specific related to metrics correlation algorithm should be covered when testing the algorithm unit itself, like in this file - https://github.com/opensearch-project/ml-commons/blob/main/ml-algorithms/src/test/java/org/opensearch/ml/engine/algorithms/metrics_correlation/MetricsCorrelationTest.java
Codecov Report
@@ Coverage Diff @@
## main #1540 +/- ##
============================================
+ Coverage 78.40% 78.41% +0.01%
- Complexity 2378 2380 +2
============================================
Files 195 195
Lines 9588 9594 +6
Branches 964 964
============================================
+ Hits 7517 7523 +6
Misses 1633 1633
Partials 438 438
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
jackiehanyang
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jackiehanyang
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jackiehanyang
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jackiehanyang
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jackiehanyang
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jackiehanyang
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
approved these changes
Oct 23, 2023
jngz-es
approved these changes
Oct 23, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
* Expose execute api for MLClient Signed-off-by: Jackie Han <jkhanjob@gmail.com> * unit test change Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 5d9324c)
dhrubo-os
pushed a commit
that referenced
this pull request
Oct 24, 2023
* Expose execute api for MLClient Signed-off-by: Jackie Han <jkhanjob@gmail.com> * unit test change Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 5d9324c) Co-authored-by: Jackie Han <jkhanjob@gmail.com>
TrungBui59
pushed a commit
to TrungBui59/ml-commons
that referenced
this pull request
Nov 6, 2023
* Expose execute api for MLClient Signed-off-by: Jackie Han <jkhanjob@gmail.com> * unit test change Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> Signed-off-by: TrungBui59 <bui23@purdue.edu>
TrungBui59
pushed a commit
to TrungBui59/ml-commons
that referenced
this pull request
Nov 6, 2023
* Expose execute api for MLClient Signed-off-by: Jackie Han <jkhanjob@gmail.com> * unit test change Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> Signed-off-by: TrungBui59 <bui23@purdue.edu>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Feb 29, 2024
* Expose execute api for MLClient Signed-off-by: Jackie Han <jkhanjob@gmail.com> * unit test change Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose execute api for MLClient
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.