-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lombok and Gradle plugins to support JDK-21 #1698
Conversation
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1698 +/- ##
============================================
+ Coverage 80.84% 80.85% +0.01%
- Complexity 4215 4217 +2
============================================
Files 404 404
Lines 16977 16977
Branches 1818 1818
============================================
+ Hits 13725 13727 +2
+ Misses 2539 2536 -3
- Partials 713 714 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@reta The JDK 21 Github CI failed |
@ylwu-amzn The build is back on track but the tests were and are still unstable (it pre-dates any recent Gradle or JDK updates). I haven't seen a single pull request that passed the checks in this repository for a loooong time, so I have no idea is that JDK-21 related or just flaky ones. Could you please retrigger failed GA actions? (I sadly have no permissions) |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1698-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df644ffecc1d5dd60ffc985a4c1aa69a947f2d79
# Push it to GitHub
git push --set-upstream origin backport/backport-1698-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Backported by #1697 |
…t#1698) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Description
Update Lombok and Gradle plugins to support JDK-21
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.