Fix Alerting tool runtime failure on ClassNotFoundException #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjun kumar Giri <arjung@amazon.com>
arjunkumargiri
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
arjunkumargiri
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
arjunkumargiri
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
arjunkumargiri
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/agent_framework_dev #1741 +/- ##
=================================================================
+ Coverage 68.60% 68.96% +0.36%
- Complexity 2591 2610 +19
=================================================================
Files 239 241 +2
Lines 12757 12815 +58
Branches 1284 1288 +4
=================================================================
+ Hits 8752 8838 +86
+ Misses 3404 3371 -33
- Partials 601 606 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dhrubo-os
reviewed
Dec 8, 2023
| @@ -48,7 +48,9 @@ dependencies { | |||
| implementation("ai.djl.onnxruntime:onnxruntime-engine:0.21.0") { | |||
| exclude group: "com.microsoft.onnxruntime", module: "onnxruntime" | |||
| } | |||
| compileOnly "org.jetbrains.kotlin:kotlin-stdlib:${kotlin_version}" | |||
| implementation("org.jetbrains.kotlin:kotlin-stdlib:${kotlin_version}") { | |||
| exclude group: "org.jetbrains", module: "annotations" | |||
There was a problem hiding this comment.
[nit] can we add a comment why are we excluding this? I saw in the PR description, but I think better to add here?
There was a problem hiding this comment.
Will merge this PR to unblock the testing, @arjunkumargiri you can add some comments in next PR
dhrubo-os
approved these changes
Dec 8, 2023
ylwu-amzn
approved these changes
Dec 8, 2023
ylwu-amzn
merged commit 44118ef
into
opensearch-project:feature/agent_framework_dev
4 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Alerting tool runtime failure on ClassNotFoundException.
Issues Resolved
Need to exclude annotation jar as it was resulting in failure
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.