[Feature/multi_tenancy] Simplify instantiating Data Object Request/Response builders #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
approved these changes
Jul 3, 2024
dhrubo-os
merged commit 18e8048
into
opensearch-project:feature/multi_tenancy
7 of 10 checks passed
arjunkumargiri
pushed a commit
to arjunkumargiri/ml-commons
that referenced
this pull request
Jul 8, 2024
…rch-project#2608) Signed-off-by: Daniel Widdis <widdis@gmail.com>
arjunkumargiri
pushed a commit
to arjunkumargiri/ml-commons
that referenced
this pull request
Jul 8, 2024
…rch-project#2608) Signed-off-by: Daniel Widdis <widdis@gmail.com>
arjunkumargiri
pushed a commit
to arjunkumargiri/ml-commons
that referenced
this pull request
Jul 8, 2024
…rch-project#2608) Signed-off-by: Daniel Widdis <widdis@gmail.com>
arjunkumargiri
pushed a commit
to arjunkumargiri/ml-commons
that referenced
this pull request
Jul 8, 2024
…rch-project#2608) Signed-off-by: Daniel Widdis <widdis@gmail.com>
arjunkumargiri
pushed a commit
to arjunkumargiri/ml-commons
that referenced
this pull request
Jul 9, 2024
…rch-project#2608) Signed-off-by: Daniel Widdis <widdis@gmail.com>
arjunkumargiri
pushed a commit
to arjunkumargiri/ml-commons
that referenced
this pull request
Jul 9, 2024
…rch-project#2608) Signed-off-by: Daniel Widdis <widdis@gmail.com>
arjunkumargiri
pushed a commit
to arjunkumargiri/ml-commons
that referenced
this pull request
Jul 9, 2024
…rch-project#2608) Signed-off-by: Daniel Widdis <widdis@gmail.com>
arjunkumargiri
pushed a commit
to arjunkumargiri/ml-commons
that referenced
this pull request
Jul 9, 2024
…rch-project#2608) Signed-off-by: Daniel Widdis <widdis@gmail.com>
arjunkumargiri
pushed a commit
to arjunkumargiri/ml-commons
that referenced
this pull request
Jul 9, 2024
…rch-project#2608) Signed-off-by: Daniel Widdis <widdis@gmail.com>
dhrubo-os
added a commit
that referenced
this pull request
Jul 11, 2024
* AWS DDB SDK client support for remote data store Signed-off-by: Arjun kumar Giri <arjung@amazon.com> * AWS DDB SDK client support for remote data store Signed-off-by: Arjun kumar Giri <arjung@amazon.com> * multi-tenancy for models (create, get, delete, update) + update connector (#2546) * multi-tenancy for models (create, get, delete) Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> * added update connector + update model Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> --------- Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Arjun kumar Giri <arjung@amazon.com> * [Feature/multi_tenancy] Add source map to GetDataObjectResponse (#2489) * Add source map to GetDataObjectResponse Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add test for map getter in clients Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Arjun kumar Giri <arjung@amazon.com> * [Feature/multi_tenancy] Add UpdateDataObject interface, Client, and Connector Implementations (#2520) * Restore original exception handling expectations Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add UpdateDataObject to interface and implementations Signed-off-by: Daniel Widdis <widdis@gmail.com> * Implement UpdateConnector action Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move CompletionException handling to a common method Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add tests for SDKClient exceptions refactored from Transport Action Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Arjun kumar Giri <arjung@amazon.com> * Addressed CR comment Signed-off-by: Arjun kumar Giri <arjung@amazon.com> * Added javadoc based on feedback Signed-off-by: Arjun kumar Giri <arjung@amazon.com> * Set tenant ID for predict request Signed-off-by: Arjun kumar Giri <arjung@amazon.com> * Simplify instantiating Data Object Request/Response builders (#2608) Signed-off-by: Daniel Widdis <widdis@gmail.com> * Addressed comments Signed-off-by: Arjun kumar Giri <arjung@amazon.com> --------- Signed-off-by: Arjun kumar Giri <arjung@amazon.com> Signed-off-by: Dhrubo Saha <dhrubo@amazon.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: arjunkumargiri <142054468+arjunkumargiri@users.noreply.github.com> Co-authored-by: Dhrubo Saha <dhrubo@amazon.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the syntax for creating builders, aligning with more common OpenSearch pattern.
Changes made via global regex search/replace.
Note: small overlap with #2605. Whichever one gets merged first let me rebase the other.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.