Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get batch task bug #2937

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

ylwu-amzn
Copy link
Collaborator

@ylwu-amzn ylwu-amzn commented Sep 12, 2024

Description

The http method hard coded as POST in AWS connector executor. That caused get remote job failed.

Related Issues

Resolves #2931

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@Zhangxunmt Zhangxunmt merged commit bbaea1c into opensearch-project:main Sep 12, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2024
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit bbaea1c)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2024
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit bbaea1c)
ylwu-amzn added a commit that referenced this pull request Sep 12, 2024
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit bbaea1c)

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn added a commit that referenced this pull request Sep 12, 2024
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit bbaea1c)

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
@dhrubo-os
Copy link
Collaborator

No unit test?

@ylwu-amzn
Copy link
Collaborator Author

ylwu-amzn commented Sep 13, 2024

No unit test?

I have too much on my plate and no one from team have bandwidth to help on this task. Have verified this fix manually, will ask @rbhavna to help add more UT/IT when she back to work, also fix another smaller bug #2938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Get batch job failed due to hard coded http method
4 participants