Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix and minor improvement in maven-publish GHA workflow. #757

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Typo fix and minor improvement in maven-publish GHA workflow. #757

merged 1 commit into from
Mar 1, 2023

Conversation

Yury-Fridlyand
Copy link
Contributor

Description

Typo fix in maven-publish GHA workflow - branch list has to be a comma-separate list or list of entries.
I also updated aws-actions/configure-aws-credentials used to avoid coming deprecation.

Issues Resolved

#755
#754

(Please, label as backport 2.x)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team February 28, 2023 22:37
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #757 (459f584) into main (0f72740) will increase coverage by 0.22%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #757      +/-   ##
============================================
+ Coverage     84.66%   84.89%   +0.22%     
- Complexity      988      990       +2     
============================================
  Files            92       92              
  Lines          3542     3542              
  Branches        326      326              
============================================
+ Hits           2999     3007       +8     
+ Misses          407      399       -8     
  Partials        136      136              
Flag Coverage Δ
ml-commons 84.89% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/ml/task/MLTaskManager.java 67.01% <0.00%> (+4.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ylwu-amzn ylwu-amzn merged commit 5c328ba into opensearch-project:main Mar 1, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 1, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 5c328ba)
Zhangxunmt pushed a commit that referenced this pull request Mar 1, 2023
#761)

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 5c328ba)

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand deleted the fix-maven-publish-ci branch March 1, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants