Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.7] Add an array filter to our serialize/deserialize methods and narrow down previous filter #857

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0997d6c from #849

…own previous filter (#849)

* Add an array filter to our serialize/deserialize methods and narrow down previous filter

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Further narrowing down accept list

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Keep narrowing down accept list

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

* Add test for deserialization methods in all built-in models

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

---------

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
(cherry picked from commit 0997d6c)
@codecov-commenter
Copy link

Codecov Report

Merging #857 (926fc05) into 2.7 (3ddec6e) will decrease coverage by 0.06%.
The diff coverage is 76.74%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.7     #857      +/-   ##
============================================
- Coverage     83.94%   83.88%   -0.06%     
- Complexity     1687     1692       +5     
============================================
  Files           138      138              
  Lines          6426     6467      +41     
  Branches        646      651       +5     
============================================
+ Hits           5394     5425      +31     
- Misses          753      758       +5     
- Partials        279      284       +5     
Flag Coverage Δ
ml-commons 83.88% <76.74%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/org/opensearch/ml/model/MLModelManager.java 76.95% <0.00%> (-0.18%) ⬇️
...java/org/opensearch/ml/profile/MLModelProfile.java 62.50% <60.00%> (-0.47%) ⬇️
...va/org/opensearch/ml/model/MLModelCacheHelper.java 86.07% <77.27%> (-1.43%) ⬇️
.../org/opensearch/ml/engine/utils/ModelSerDeSer.java 83.33% <100.00%> (+3.33%) ⬆️
...ain/java/org/opensearch/ml/model/MLModelCache.java 84.28% <100.00%> (+0.46%) ⬆️
...va/org/opensearch/ml/rest/RestMLProfileAction.java 94.73% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@b4sjoo b4sjoo merged commit 3e33f0d into 2.7 Apr 17, 2023
@github-actions github-actions bot deleted the backport/backport-849-to-2.7 branch April 17, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants