Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to main] Add memory consumption estimation for models in profile API. (#853) #991

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Jun 16, 2023

Description

Backport PR #853 to main branch

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #991 (a084d5a) into main (bdd1388) will decrease coverage by 0.07%.
The diff coverage is 73.68%.

@@             Coverage Diff              @@
##               main     #991      +/-   ##
============================================
- Coverage     83.92%   83.85%   -0.07%     
- Complexity     1691     1696       +5     
============================================
  Files           138      138              
  Lines          6425     6462      +37     
  Branches        646      651       +5     
============================================
+ Hits           5392     5419      +27     
- Misses          753      758       +5     
- Partials        280      285       +5     
Flag Coverage Δ
ml-commons 83.85% <73.68%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/org/opensearch/ml/model/MLModelManager.java 76.95% <0.00%> (-0.18%) ⬇️
...java/org/opensearch/ml/profile/MLModelProfile.java 62.50% <60.00%> (-0.47%) ⬇️
...va/org/opensearch/ml/model/MLModelCacheHelper.java 86.07% <77.27%> (-1.43%) ⬇️
...ain/java/org/opensearch/ml/model/MLModelCache.java 84.28% <100.00%> (+0.46%) ⬆️
...va/org/opensearch/ml/rest/RestMLProfileAction.java 94.73% <100.00%> (+0.11%) ⬆️

@rbhavna rbhavna merged commit 42fa5cd into opensearch-project:main Jun 16, 2023
@rbhavna rbhavna deleted the backport_2.x_to_main branch June 16, 2023 20:48
@ylwu-amzn ylwu-amzn changed the title Add memory consumption estimation for models in profile API. (#853) [Backport to main] Add memory consumption estimation for models in profile API. (#853) Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants