[Backport to main] Add an array filter to our serialize/deserialize methods and narrow d… #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…own previous filter (opensearch-project#849) * Add an array filter to our serialize/deserialize methods and narrow down previous filter Signed-off-by: Sicheng Song <sicheng.song@outlook.com> * Further narrowing down accept list Signed-off-by: Sicheng Song <sicheng.song@outlook.com> * Keep narrowing down accept list Signed-off-by: Sicheng Song <sicheng.song@outlook.com> * Add test for deserialization methods in all built-in models Signed-off-by: Sicheng Song <sicheng.song@outlook.com> --------- Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
rbhavna
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
wujunshen,
ylwu-amzn,
zane-neo and
Zhangxunmt
as code owners
Zhangxunmt
approved these changes
Jun 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #993 +/- ##
============================================
+ Coverage 83.79% 83.86% +0.07%
- Complexity 1694 1696 +2
============================================
Files 138 138
Lines 6462 6466 +4
Branches 651 651
============================================
+ Hits 5415 5423 +8
+ Misses 761 758 -3
+ Partials 286 285 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dhrubo-os
approved these changes
Jun 16, 2023
6 tasks
ylwu-amzn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…own previous filter (#849)
Description
Backport PR #849 to main branch
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.