-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create custom neural query #14
Comments
@jmazanec15 can you provide details on what will be optional parameters and what are required parameters. |
vector_field — (REQUIRED) Field to execute k-NN query against |
5 tasks
jmazanec15
added
v2.4.0
Features
Introduces a new unit of functionality that satisfies a requirement
labels
Oct 17, 2022
zane-neo
added a commit
to zane-neo/neural-search
that referenced
this issue
Oct 20, 2022
# This is the 1st commit message: Add text embedding processor to neural search Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message opensearch-project#2 will be skipped: # Code format # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message opensearch-project#3 will be skipped: # Address review comments # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message opensearch-project#4 will be skipped: # Add blocking text embedding method for pipeline processor # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message opensearch-project#5 will be skipped: # Add BaseNeuralSearchIT and address other review comments # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message opensearch-project#6 will be skipped: # Add BaseNeuralSearchIT and address other review comments # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message opensearch-project#7 will be skipped: # Add BaseNeuralSearchIT and address other review comments # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message opensearch-project#8 will be skipped: # Fix naming convention and IT function move to base # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message opensearch-project#9 will be skipped: # Fix naming convention and IT function move to base # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message opensearch-project#10 will be skipped: # Update src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java # # Co-authored-by: Navneet Verma <vermanavneet003@gmail.com> # The commit message opensearch-project#11 will be skipped: # Update src/main/java/org/opensearch/neuralsearch/processor/TextEmbeddingProcessor.java # # Co-authored-by: Navneet Verma <vermanavneet003@gmail.com> # The commit message opensearch-project#12 will be skipped: # Fix code review comments # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message opensearch-project#13 will be skipped: # Fix text embedding processor NPE # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message opensearch-project#14 will be skipped: # Remove jackson dependencies and fix tests with XCoontent # # Signed-off-by: Zan Niu <zaniu@amazon.com>
zane-neo
added a commit
that referenced
this issue
Oct 20, 2022
* # This is a combination of 14 commits. # This is the 1st commit message: Add text embedding processor to neural search Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message #2 will be skipped: # Code format # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message #3 will be skipped: # Address review comments # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message #4 will be skipped: # Add blocking text embedding method for pipeline processor # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message #5 will be skipped: # Add BaseNeuralSearchIT and address other review comments # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message #6 will be skipped: # Add BaseNeuralSearchIT and address other review comments # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message #7 will be skipped: # Add BaseNeuralSearchIT and address other review comments # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message #8 will be skipped: # Fix naming convention and IT function move to base # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message #9 will be skipped: # Fix naming convention and IT function move to base # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message #10 will be skipped: # Update src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java # # Co-authored-by: Navneet Verma <vermanavneet003@gmail.com> # The commit message #11 will be skipped: # Update src/main/java/org/opensearch/neuralsearch/processor/TextEmbeddingProcessor.java # # Co-authored-by: Navneet Verma <vermanavneet003@gmail.com> # The commit message #12 will be skipped: # Fix code review comments # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message #13 will be skipped: # Fix text embedding processor NPE # # Signed-off-by: Zan Niu <zaniu@amazon.com> # The commit message #14 will be skipped: # Remove jackson dependencies and fix tests with XCoontent # # Signed-off-by: Zan Niu <zaniu@amazon.com> * Add text embedding processor to neural search Signed-off-by: Zan Niu <zaniu@amazon.com> * Remove unnecessary parameters in TextEmbeddingProcessor method Signed-off-by: Zan Niu <zaniu@amazon.com> * Remove unnecessary empty string checks Signed-off-by: Zan Niu <zaniu@amazon.com> * Add field max depth limit to prevent malicious attack Signed-off-by: Zan Niu <zaniu@amazon.com> Signed-off-by: Zan Niu <zaniu@amazon.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Create a new query type: "neural". Internally, it will use ML-Commons to take a query string and create a vector from it. From there, it should build a k-NN query.
Interface will look like:
vector_field — Field to execute k-NN query against
query_text — (string) Query text to be used to produce queries against.
model_id — (string) ID of model to do vector to encoding.
k — (int) Number of results to return from the k-NN search
For more details, refer to #11 (comment)
The text was updated successfully, but these errors were encountered: