-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed compilation errors after refactoring in core Strings class #243
Merged
martin-gaievski
merged 1 commit into
main
from
fix_errors_after_core_refactoring_in_strings_class
Aug 7, 2023
Merged
Fixed compilation errors after refactoring in core Strings class #243
martin-gaievski
merged 1 commit into
main
from
fix_errors_after_core_refactoring_in_strings_class
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
added
backport 2.x
Label will add auto workflow to backport PR to 2.x branch
skip-changelog
labels
Aug 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #243 +/- ##
=========================================
Coverage 86.23% 86.23%
Complexity 337 337
=========================================
Files 28 28
Lines 981 981
Branches 153 153
=========================================
Hits 846 846
Misses 69 69
Partials 66 66 |
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
wujunshen,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
August 7, 2023 17:57
heemin32
approved these changes
Aug 7, 2023
vibrantvarun
approved these changes
Aug 7, 2023
navneet1v
approved these changes
Aug 7, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-243-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9c86a817e7c2b421430624ea629fcc8908da374
# Push it to GitHub
git push --set-upstream origin backport/backport-243-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
navneet1v
pushed a commit
to navneet1v/neural-search
that referenced
this pull request
Aug 17, 2023
…nsearch-project#243) Signed-off-by: Martin Gaievski <gaievski@amazon.com>
navneet1v
added a commit
that referenced
this pull request
Aug 17, 2023
….x branch (#253) * Fixed compilation errors after refactoring in core (#249) Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Fixing test classes after core refactoring (#237) Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Fixed compilation errors after refactoring in core Strings class (#243) Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Switch from XContentType to MediaType to fix compilation errors (#232) Signed-off-by: Martin Gaievski <gaievski@amazon.com> * Fixing the Media type being not able to be read from Headers. Signed-off-by: Navneet Verma <navneev@amazon.com> --------- Signed-off-by: Martin Gaievski <gaievski@amazon.com> Signed-off-by: Navneet Verma <navneev@amazon.com> Co-authored-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed compilation errors after changes in core Strings classes (core PR)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.