Fixed unit test for neural query after recent knn change in rescore context #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontext Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
added
backport 2.x
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es,
vibrantvarun,
zhichao-aws and
yuye-aws
as code owners
5 tasks
|
BWC will keep failing until packages with opensearch-project/k-NN#2195 got propagated to all maven repos |
|
@martin-gaievski The code looks good to me. Shall we wait for the k-NN change to fix the BWC tests? |
I don't think we need to wait, we need changes from this PR anyways, and propagation of build artifacts can take days |
yuye-aws
approved these changes
Oct 10, 2024
|
@martin-gaievski I've verified that UT can pass with your PR. Thanks for creating this PR. |
|
Pinging @navneet1v and @vibrantvarun for code review. |
vibrantvarun
approved these changes
Oct 10, 2024
martin-gaievski
merged commit ba94f75
into
opensearch-project:main
39 of 58 checks passed
martin-gaievski
added a commit
to Johnsonisaacn/neural-search
that referenced
this pull request
Oct 11, 2024
…ontext (opensearch-project#927) Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed unit test for neural query after recent push in k-NN opensearch-project/k-NN#2183. In that PR k-NN team has added a field
userProvidedto RescoreContext, and by default it'sfalse, but anything user provided istrue. Because of this theequalscheck in RescoreContext class start failing, and we need to compare only on certain fields.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.