[documentation] Adds documentation to help fix local Lucene code errors #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Flores <iflorbri@amazon.com>
brianf-aws
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es,
vibrantvarun,
zhichao-aws and
yuye-aws
as code owners
|
I do not have much context on lucene codec PR: https://github.com/opensearch-project/k-NN/pull/2195/files. Can @navneet1v help review? |
navneet1v
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Its surprise to see that GH actions are failing even though there is no change in the src files. @vibrantvarun , @martin-gaievski is it expected?
I see one BWC test got cancelled, looks like a transient issue. |
Signed-off-by: Brian Flores <iflorbri@amazon.com>
Signed-off-by: Brian Flores <iflorbri@amazon.com>
Signed-off-by: Brian Flores <iflorbri@amazon.com>
martin-gaievski
merged commit a77ccac
into
opensearch-project:main
36 of 37 checks passed
martin-gaievski
added
the
backport 2.x
martin-gaievski
pushed a commit
that referenced
this pull request
Nov 18, 2024
…rs (#928) * Adds documentation to help fix local Lucene code errors Signed-off-by: Brian Flores <iflorbri@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds documentation to help fix local Lucene code errors. You can check this PR as an example of this event happening.
Resolves development block when a Lucene version update occurs
Related Issues
N/A
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.