Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed xContent changes #646

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

Angie-Zhang
Copy link

@Angie-Zhang Angie-Zhang commented Mar 28, 2023

Description

Fixed build failure due to OSCore xContent changes

Issues Resolved

#645

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Angie Zhang <langelzh@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #646 (836394d) into 2.x (974dba3) will increase coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x     #646      +/-   ##
============================================
+ Coverage     61.36%   61.38%   +0.01%     
  Complexity      112      112              
============================================
  Files            73       73              
  Lines          2472     2473       +1     
  Branches        265      265              
============================================
+ Hits           1517     1518       +1     
  Misses          778      778              
  Partials        177      177              
Flag Coverage Δ
opensearch-notifications 61.38% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...earch/notifications/core/NotificationCorePlugin.kt 84.61% <ø> (ø)
...org/opensearch/notifications/core/utils/Helpers.kt 100.00% <ø> (ø)
...org/opensearch/notifications/NotificationPlugin.kt 97.43% <ø> (ø)
...fications/action/CreateNotificationConfigAction.kt 81.81% <ø> (ø)
...fications/action/DeleteNotificationConfigAction.kt 81.81% <ø> (ø)
...earch/notifications/action/GetChannelListAction.kt 81.81% <ø> (ø)
...otifications/action/GetNotificationConfigAction.kt 81.81% <ø> (ø)
...ch/notifications/action/GetPluginFeaturesAction.kt 84.61% <ø> (ø)
.../notifications/action/PublishNotificationAction.kt 72.72% <ø> (ø)
...rch/notifications/action/SendNotificationAction.kt 81.81% <ø> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Angie-Zhang Angie-Zhang marked this pull request as ready for review March 28, 2023 23:46
@Angie-Zhang Angie-Zhang requested a review from a team March 28, 2023 23:46
@Angie-Zhang Angie-Zhang changed the title Fixed build failure due to OSCore xContent changes Fixed build failure due to OSCore xContent changes with backport #640 Mar 28, 2023
@Angie-Zhang Angie-Zhang changed the title Fixed build failure due to OSCore xContent changes with backport #640 Fixed xContent changes with backport #640 Mar 28, 2023
@Angie-Zhang Angie-Zhang changed the title Fixed xContent changes with backport #640 Fixed xContent changes Mar 29, 2023
@Angie-Zhang
Copy link
Author

Failed workflows will be fixed/removed in #647

@Angie-Zhang Angie-Zhang merged commit 28715d1 into opensearch-project:2.x Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants