-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JDK-23 to the build matrix #977
Conversation
This is for |
@reta Can you check the error from JDK 23: https://github.com/opensearch-project/notifications/actions/runs/11482952177/job/31981106157?pr=977. It shows |
@reta to support java 23, jacoco need upgrade to 0.8.12, not sure whether have more libs need to upgrade. Also java 23 is not LTS version, we might not rush for supporting this. |
@yuye-aws will do, thank you
@Hailong-am I will check thank you
We don't do anything in particular to support it, beside just adding to build / test matrix. The |
@yuye-aws @Hailong-am updated outdated deps, should be all set, thanks folks! |
@reta Can you rebase? |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@yuye-aws mind please taking a look? thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add JDK-23 to the build matrix
Related Issues
N/A
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.