Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDK-23 to the build matrix #977

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Oct 23, 2024

Description

Add JDK-23 to the build matrix

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Contributor Author

reta commented Oct 23, 2024

This is for main only at the moment (no 2.x backport)

yuye-aws
yuye-aws previously approved these changes Oct 24, 2024
@yuye-aws
Copy link
Member

@reta Can you check the error from JDK 23: https://github.com/opensearch-project/notifications/actions/runs/11482952177/job/31981106157?pr=977. It shows Unsupported class file major version 67.

@Hailong-am
Copy link
Collaborator

@reta Can you check the error from JDK 23: https://github.com/opensearch-project/notifications/actions/runs/11482952177/job/31981106157?pr=977. It shows Unsupported class file major version 67.

@reta to support java 23, jacoco need upgrade to 0.8.12, not sure whether have more libs need to upgrade.

Also java 23 is not LTS version, we might not rush for supporting this.

@reta
Copy link
Contributor Author

reta commented Oct 24, 2024

@reta Can you check the error from JDK 23: https://github.com/opensearch-project/notifications/actions/runs/11482952177/job/31981106157?pr=977. It shows Unsupported class file major version 67.

@yuye-aws will do, thank you

@reta to support java 23, jacoco need upgrade to 0.8.12, not sure whether have more libs need to upgrade.

@Hailong-am I will check thank you

Also java 23 is not LTS version, we might not rush for supporting this.

We don't do anything in particular to support it, beside just adding to build / test matrix. The main is build with JDK 23 now.

@reta
Copy link
Contributor Author

reta commented Oct 24, 2024

@yuye-aws @Hailong-am updated outdated deps, should be all set, thanks folks!

@yuye-aws
Copy link
Member

@reta Can you rebase?

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta
Copy link
Contributor Author

reta commented Nov 30, 2024

@yuye-aws mind please taking a look? thank you

Copy link
Member

@yuye-aws yuye-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hailong-am Hailong-am merged commit 5af90be into opensearch-project:main Dec 2, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants