Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Validator class for Integrations #1464

Closed
wants to merge 29 commits into from
Closed

Implement Validator class for Integrations #1464

wants to merge 29 commits into from

Commits on Mar 6, 2023

  1. Stub Integration Validator 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    4ee0e6f View commit details
    Browse the repository at this point in the history

  2. Wrap non-validation exceptions with ValidationException 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    b406beb View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Rename ValidationException for precision 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    9819d60 View commit details
    Browse the repository at this point in the history

  2. Add to validation logic 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    eb8a8bd View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Switch to using Medeia for schema validation 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    5f239e6 View commit details
    Browse the repository at this point in the history

  2. Generalize Validator to check generic components 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    54592db View commit details
    Browse the repository at this point in the history

  3. Configure to use existing schema directory 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    4a2dc4d View commit details
    Browse the repository at this point in the history

  4. Apply Detekt feedback 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    875ce81 View commit details
    Browse the repository at this point in the history

  5. Make Validator return XContentParser instead of JsonNode 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    0baf708 View commit details
    Browse the repository at this point in the history

  6. Tweak integration to better line up with example 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    11b6723 View commit details
    Browse the repository at this point in the history

  7. Apply Ktlint feedback 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    b675db2 View commit details
    Browse the repository at this point in the history

  8. Switch from Medeia to NetworkNT Validator 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    1731198 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Move SystemComponent to own package 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    4339d25 View commit details
    Browse the repository at this point in the history

  2. Break up sample validation tests by component 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    91fe11c View commit details
    Browse the repository at this point in the history

  3. Add check for extra field validation 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    16f932c View commit details
    Browse the repository at this point in the history

  4. Document Validator 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    0d78a17 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Move schema folder to resources 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    4e524be View commit details
    Browse the repository at this point in the history

  2. Move schema documentation to docs 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    acef283 View commit details
    Browse the repository at this point in the history

  3. Move rest of schema documentation to docs 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    139609c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Merge branch 'move-schema' into validation

    @Swiddis
    Swiddis committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    b975744 View commit details
    Browse the repository at this point in the history

  2. Refactor validation to separate integrations package 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    e0b3b1a View commit details
    Browse the repository at this point in the history

  3. Refactor Validator to use results instead of exception throwing 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2e1a21d View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/2.x' into validation

    @Swiddis
    Swiddis committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    311a94a View commit details
    Browse the repository at this point in the history

  5. Fix failing tests 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    97d51c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Add more documentation 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    f67e743 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/2.x' into validation

    @Swiddis
    Swiddis committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    ee02a92 View commit details
    Browse the repository at this point in the history

  3. Fix unused imports 

    Signed-off-by: Simeon Widdis <sawiddis@gmail.com>
    @Swiddis
    Swiddis committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    f55fb3a View commit details
    Browse the repository at this point in the history

  4. Refactor Validator to return sealed result type 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    a237986 View commit details
    Browse the repository at this point in the history

  5. Apply lint 

    Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
    @Swiddis
    Swiddis committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    93882a4 View commit details
    Browse the repository at this point in the history