tenancy access control #1821
Merged
tenancy access control #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Kao <seankao@amazon.com>
seankao-az
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo and
anirudha
as code owners
joshuali925
previously approved these changes
Apr 25, 2024
rupal-bq
previously approved these changes
Apr 25, 2024
Signed-off-by: Sean Kao <seankao@amazon.com>
seankao-az
force-pushed
the
tenancy-access-control
branch
from
6df3b4a
to
d005f4c
Compare
|
The remaining one failed link checker is on DEVELOPER_GUIDE.md, which is an outdated doc itself. The doc is written for dashboards-observability setup. Will just remove the link to satisfy the link check for now. |
Signed-off-by: Sean Kao <seankao@amazon.com>
rupal-bq
approved these changes
Apr 25, 2024
ps48
approved these changes
Apr 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Check user name for private tenant access control Signed-off-by: Sean Kao <seankao@amazon.com> * fix broken link Signed-off-by: Sean Kao <seankao@amazon.com> * remove broken link Signed-off-by: Sean Kao <seankao@amazon.com> --------- Signed-off-by: Sean Kao <seankao@amazon.com> (cherry picked from commit de18327) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seankao-az
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Check user name for private tenant access control * fix broken link * remove broken link --------- (cherry picked from commit de18327) Signed-off-by: Sean Kao <seankao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.