Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Analytics bug fixes #782

Conversation

eugenesk24
Copy link
Contributor

@eugenesk24 eugenesk24 commented Jun 6, 2022

Description

Modularization and bug fixes for 1.3.3 release.
Needed to also cherry-pick modularization commits because bug fixes were made on that version of the code.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

eugenesk24 and others added 17 commits June 6, 2022 11:01
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
* Do not include minimum_should_match if no app configs

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Add all comparison operators to availability levels

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Set availability as undefined if most current value is null

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Use parse get suggestions for all autocompelte

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Fix autocomplete tests

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Calculate availability by row for app table while showing loading spinner in meantime

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Add cypress tests for bugs

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Update snapshots

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Update snaphosts

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Update snapshots again

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* Remove obsolete snapshots:

Signed-off-by: Eugene Lee <eugenesk@amazon.com>
* remove button toggle and add stop button

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update cypress

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
)

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #782 (415d28b) into 1.3 (6461026) will increase coverage by 0.41%.
The diff coverage is 40.12%.

@@             Coverage Diff              @@
##                1.3     #782      +/-   ##
============================================
+ Coverage     53.23%   53.64%   +0.41%     
  Complexity      271      271              
============================================
  Files           236      244       +8     
  Lines          7780     7728      -52     
  Branches       1653     1600      -53     
============================================
+ Hits           4142     4146       +4     
+ Misses         3436     3387      -49     
+ Partials        202      195       -7     
Flag Coverage Δ
dashboards-observability 46.51% <40.12%> (+0.49%) ⬆️
opensearch-observability 72.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lytics/components/config_components/log_config.tsx 74.19% <ø> (+2.31%) ⬆️
...tics/components/config_components/trace_config.tsx 46.23% <ø> (ø)
...nts/flyout_components/availability_info_flyout.tsx 0.00% <0.00%> (ø)
...components/application_analytics/helpers/utils.tsx 5.73% <0.00%> (-0.87%) ⬇️
...ty/public/components/common/search/date_picker.tsx 0.00% <0.00%> (ø)
...ponents/custom_panels/helpers/modal_containers.tsx 80.00% <ø> (+7.77%) ⬆️
...isualization_container/visualization_container.tsx 2.27% <0.00%> (+0.09%) ⬆️
...ity/public/components/explorer/sidebar/sidebar.tsx 80.64% <ø> (ø)
...onfig_editor/config_controls/config_thresholds.tsx 3.44% <0.00%> (+0.88%) ⬆️
...tions/config_panel/config_editor/config_editor.tsx 33.33% <ø> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6461026...415d28b. Read the comment docs.

@eugenesk24 eugenesk24 marked this pull request as ready for review June 6, 2022 23:05
@eugenesk24 eugenesk24 merged commit 13748f9 into opensearch-project:1.3 Jun 6, 2022
@eugenesk24 eugenesk24 deleted the cherry-pick-modularization-and-bug-fixes-for-1.3.3 branch June 6, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants