Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Persian stem token filter #444

Closed
wants to merge 1 commit into from

Conversation

ebraminio
Copy link

@ebraminio ebraminio commented Jul 21, 2024

Description

Add Persian stem token filter API documentation

Issues Resolved

Related to opensearch-project/OpenSearch#14847

This is based on PorterStemTokenFilter

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please write a test for it and add to CHANGELOG.

Copy link
Contributor

github-actions bot commented Jul 21, 2024

Changes Analysis

Commit SHA: ae4c817
Comparing To SHA: bf2772a

API Changes

Summary


└─┬Components
  └──[➕] schemas (32921:7)

Document Element Total Changes Breaking Changes
components 1 0
  • Total Changes: 1
  • Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10030140918/artifacts/1726028949

API Coverage

Before After Δ
Covered (%) 490 (47.99 %) 490 (47.99 %) 0 (0 %)
Uncovered (%) 531 (52.01 %) 531 (52.01 %) 0 (0 %)
Unknown 24 24 0

Signed-off-by: Ebrahim Byagowi <ebrahim@gnu.org>
@ebraminio
Copy link
Author

@dblock Added the changelog 😊 I'm yet figuring out how to add a test as there is not any test for any other filter as far as I can see

@dblock
Copy link
Member

dblock commented Jul 22, 2024

@dblock Added the changelog 😊 I'm yet figuring out how to add a test as there is not any test for any other filter as far as I can see

Yes, appreciate if you could write some for other filters as well, start with something simple and work from there. We have a testing guide: https://github.com/opensearch-project/opensearch-api-specification/blob/main/TESTING_GUIDE.md, too.

Since this is in the next version you will have to bump the docker hub ref in CI as well, https://github.com/opensearch-project/opensearch-api-specification/blob/main/.github/workflows/test-spec.yml#L29.

@ebraminio ebraminio mentioned this pull request Jul 22, 2024
@dblock dblock mentioned this pull request Sep 30, 2024
@dblock
Copy link
Member

dblock commented Sep 30, 2024

Finishing this in #592.

@Xtansia Xtansia closed this in #592 Sep 30, 2024
@ebraminio ebraminio deleted the persian-stem branch October 1, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants