-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workload management querygroup api specs #649
Conversation
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Changes AnalysisCommit SHA: dae9c98 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11601758306/artifacts/2125468248 API Coverage
|
Spec Test Coverage Analysis
|
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Workload Management plugin is only available in 2.17.0, but when I use the default ${OPENSEARCH_VERSION:-latest} in docker-compose file, it only gives 2.14.0. So I hardcoded 2.17.0 in it. I'm wondering if there's any better ways of doing it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The docker compose in tests/plugins/wlm
is identical to the default one. We do custom plugins/xyz
for when additional setup is required, so move this into tests/default
and you don't need a special entry in the CI matrix.
The default docker compose uses ${OPENSEARCH_VERSION:-latest} which is 2.14.0, but we need 2.17.0 here. That's why I put the tests in plugin since we need Dockerfile (to install the workload-management plugin) and docker compose with version 2.17.0 |
You should upgrade that number, and it's 2.17 in CI: https://github.com/opensearch-project/opensearch-api-specification/blob/main/.github/workflows/test-spec.yml |
wlm is not installed by default. So we still need a separate dockerfile to install it and think it should be in the plugins directory |
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Sorry to be a pest, the plugin is called |
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Thanks for hanging in here with me.
@@ -106,6 +106,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
- Added `config_id` and `config_id_list` to `/_plugins/_notifications/configs` query parameters ([#594](https://github.com/opensearch-project/opensearch-api-specification/pull/594)) | |||
- Added a release workflow triggered on a tag ([#635](https://github.com/opensearch-project/opensearch-api-specification/pull/635)) | |||
- Added API spec for query insights plugin ([#625](https://github.com/opensearch-project/opensearch-api-specification/pull/625)) | |||
- Added API specs for query groups lifecycle APIs ([#649](https://github.com/opensearch-project/opensearch-api-specification/pull/649)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruai0511 I missed this, but we released 0.1.0, could you please move this in another PR to the unreleased section? thanks
Description
API spec for workload management, more specifically, for the query group lifecycle APIs.
Related PR: opensearch-project/OpenSearch#14680, opensearch-project/OpenSearch#14775, opensearch-project/OpenSearch#14735, opensearch-project/OpenSearch#14709