Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract TaskInfoBase #683

Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Nov 20, 2024

Description

Extract TaskInfoBase

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia force-pushed the fix/extract-task-info-base-schema branch from 5bf42f4 to c9a85b6 Compare November 20, 2024 00:54
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Changes Analysis

Commit SHA: c9a85b6
Comparing To SHA: a22a61d

API Changes

Summary

└─┬Components
  ├──[➕] schemas (57589:7)
  ├─┬tasks._common___TaskInfo
  │ ├──[➖] required (57621:11)❌ 
  │ ├──[➖] required (57622:11)❌ 
  │ ├──[➖] required (57623:11)❌ 
  │ ├──[➖] required (57616:11)❌ 
  │ ├──[➖] required (57617:11)❌ 
  │ ├──[➖] required (57618:11)❌ 
  │ ├──[➖] required (57619:11)❌ 
  │ ├──[➖] required (57620:11)❌ 
  │ ├──[➖] type (57584:13)❌ 
  │ ├──[➖] properties (57586:9)❌ 
  │ ├──[➖] properties (57590:9)❌ 
  │ ├──[➖] properties (57588:9)❌ 
  │ ├──[➖] properties (57592:9)❌ 
  │ ├──[➖] properties (57594:9)❌ 
  │ ├──[➖] properties (57598:9)❌ 
  │ ├──[➖] properties (57601:9)❌ 
  │ ├──[➖] properties (57613:9)❌ 
  │ ├──[➖] properties (57603:9)❌ 
  │ ├──[➖] properties (57605:9)❌ 
  │ ├──[➖] properties (57607:9)❌ 
  │ ├──[➖] properties (57609:9)❌ 
  │ ├──[➖] properties (57611:9)❌ 
  │ ├──[➕] allOf (57586:11)
  │ └──[➕] allOf (57589:7)
  └─┬tasks._common___TaskGroup
    └─┬ALLOF
      └──[🔀] $ref (57589:13)❌ 

Document Element Total Changes Breaking Changes
components 26 24
  • BREAKING Changes: 24 out of 26
  • Modifications: 1
  • Removals: 22
  • Additions: 3
  • Breaking Removals: 22
  • Breaking Modifications: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11924592587/artifacts/2210678939

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
528 366 (69.32 %)

@dblock dblock merged commit 1ce89fe into opensearch-project:main Nov 20, 2024
26 checks passed
@Xtansia Xtansia deleted the fix/extract-task-info-base-schema branch November 20, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants