Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: _cat/snapshots takes a repository in the query. #700

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 29, 2024

Description

The _cat/snapshots API takes a repository in the query.

Issues Resolved

Coming from opensearch-project/OpenSearch#16648.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 29, 2024

Changes Analysis

Commit SHA: e9a740a
Comparing To SHA: c400057

API Changes

Summary

├─┬Paths
│ ├─┬/_cat/snapshots
│ │ └─┬GET
│ │   └──[➕] parameters (16590:13)❌ 
│ └─┬/_cat/snapshots/{repository}
│   └─┬GET
│     └─┬Parameters
│       ├──[➖] style (16535:14)
│       └──[🔀] in (16589:11)❌ 
└─┬Components
  └──[➕] parameters (16589:7)

Document Element Total Changes Breaking Changes
paths 3 2
components 1 0
  • BREAKING Changes: 2 out of 4
  • Modifications: 1
  • Removals: 1
  • Additions: 2
  • Breaking Modifications: 1
  • Breaking Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12090868296/artifacts/2255466728

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
528 411 (77.84 %)

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock changed the title Fix: _cat/snapshot takes a repository in the query. Fix: _cat/snapshots takes a repository in the query. Nov 29, 2024
@nhtruong nhtruong merged commit 1ef6968 into opensearch-project:main Dec 2, 2024
29 checks passed
@dblock dblock deleted the fix-cat-snapshot branch December 2, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants