Generating import file for postman #770
Conversation
Signed-off-by: Tokesh <tokesh789@gmail.com>
Changes AnalysisCommit SHA: f17ed0a API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12658031691/artifacts/2397681920 API Coverage
|
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
|
TODO:
|
Spec Test Coverage Analysis
|
Signed-off-by: Tokesh <tokesh789@gmail.com>
Tokesh
changed the title
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
There was a problem hiding this comment.
This is a good start.
You should separate responsibilities better and call things by their name. Let me explain. The ChapterReader's job is to read chapters but to execute tests, it's certainly not to collect collections for Postman.
Build a new tool like the merger or linter called maybe exporter. It should use the existing classes to read the spec tests, then export them into various formats, one of which would be Postman.
| @@ -221,6 +221,13 @@ export class OpenSearchHttpClient { | |||
| } | |||
| } | |||
|
|
|||
| get_url(): string | undefined { | |||
| if (this._opts != null && this._opts.url != null && this._opts.url !== '') { | |||
There was a problem hiding this comment.
I think lodash isEmpty can this this cleaner, maybe just _.isEmpty(this._opts?.url) ? DEFAULT_URL : this._opts?.url.
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Description
Generating file which importable for Postman
Issues Resolved
[#659]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.