-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to include additional information on expand-data-corpus.py beta feature (#92) #93
Conversation
…pus.py beta feature (opensearch-project#92) Signed-off-by: Ian Hoang <hoangia@amazon.com>
Let's add some more details in the documentation about provision of defining private workloads and how it differs from "default" workload. |
I'll also add info in the README.md there's already a parameter to specify repository to make the changes in.
|
http_logs/README.md
Outdated
@@ -64,6 +64,7 @@ Once a corpus has been generated, it can be used for a test by supplying the fol | |||
|
|||
If there are multiple generated corpora files, they are all used concurrently. Ingestion of the generated and the default corpora are mutually exclusive in any single OSB run. Once ingested, however, queries packaged with this workload will operate on the entire loaded data set. | |||
|
|||
To see how this feature changes http_logs workload, visit the `~/.benchmark/benchmarks/workloads/default/http_logs/` directory and the `~/.benchmark/data/http_logs` directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "the" http_logs workload
Signed-off-by: Ian Hoang <hoangia@amazon.com>
@ayushav12 this is a good idea. However, we can add this to the official documentation as this README is pertains to the official workloads (default workloads) that come with OSB |
…pus.py beta feature (opensearch-project#92) (opensearch-project#93) * Update README.md to include additional information on expand-data-corpus.py beta feature (opensearch-project#92) Signed-off-by: Ian Hoang <hoangia@amazon.com> * Revised README to better specify expand-data-corpus.py feature Signed-off-by: Ian Hoang <hoangia@amazon.com> --------- Signed-off-by: Ian Hoang <hoangia@amazon.com> Co-authored-by: Ian Hoang <hoangia@amazon.com>
…pus.py beta feature (opensearch-project#92) (opensearch-project#93) * Update README.md to include additional information on expand-data-corpus.py beta feature (opensearch-project#92) Signed-off-by: Ian Hoang <hoangia@amazon.com> * Revised README to better specify expand-data-corpus.py feature Signed-off-by: Ian Hoang <hoangia@amazon.com> --------- Signed-off-by: Ian Hoang <hoangia@amazon.com> Co-authored-by: Ian Hoang <hoangia@amazon.com> Signed-off-by: Govind Kamat <govkamat@amazon.com>
…pus.py beta feature (#92) (#93) * Update README.md to include additional information on expand-data-corpus.py beta feature (#92) Signed-off-by: Ian Hoang <hoangia@amazon.com> * Revised README to better specify expand-data-corpus.py feature Signed-off-by: Ian Hoang <hoangia@amazon.com> --------- Signed-off-by: Ian Hoang <hoangia@amazon.com> Co-authored-by: Ian Hoang <hoangia@amazon.com> Signed-off-by: Govind Kamat <govkamat@amazon.com>
…pus.py beta feature (opensearch-project#92) (opensearch-project#93) * Update README.md to include additional information on expand-data-corpus.py beta feature (opensearch-project#92) Signed-off-by: Ian Hoang <hoangia@amazon.com> * Revised README to better specify expand-data-corpus.py feature Signed-off-by: Ian Hoang <hoangia@amazon.com> --------- Signed-off-by: Ian Hoang <hoangia@amazon.com> Co-authored-by: Ian Hoang <hoangia@amazon.com> Signed-off-by: Govind Kamat <govkamat@amazon.com>
…pus.py beta feature (#92) (#93) * Update README.md to include additional information on expand-data-corpus.py beta feature (#92) Signed-off-by: Ian Hoang <hoangia@amazon.com> * Revised README to better specify expand-data-corpus.py feature Signed-off-by: Ian Hoang <hoangia@amazon.com> --------- Signed-off-by: Ian Hoang <hoangia@amazon.com> Co-authored-by: Ian Hoang <hoangia@amazon.com> Signed-off-by: Govind Kamat <govkamat@amazon.com>
…pus.py beta feature (opensearch-project#92) (opensearch-project#93) * Update README.md to include additional information on expand-data-corpus.py beta feature (opensearch-project#92) Signed-off-by: Ian Hoang <hoangia@amazon.com> * Revised README to better specify expand-data-corpus.py feature Signed-off-by: Ian Hoang <hoangia@amazon.com> --------- Signed-off-by: Ian Hoang <hoangia@amazon.com> Co-authored-by: Ian Hoang <hoangia@amazon.com>
…pus.py beta feature (opensearch-project#92) (opensearch-project#93) * Update README.md to include additional information on expand-data-corpus.py beta feature (opensearch-project#92) Signed-off-by: Ian Hoang <hoangia@amazon.com> * Revised README to better specify expand-data-corpus.py feature Signed-off-by: Ian Hoang <hoangia@amazon.com> --------- Signed-off-by: Ian Hoang <hoangia@amazon.com> Co-authored-by: Ian Hoang <hoangia@amazon.com> Signed-off-by: Govind Kamat <govkamat@amazon.com>
…pus.py beta feature (opensearch-project#92) (opensearch-project#93) * Update README.md to include additional information on expand-data-corpus.py beta feature (opensearch-project#92) Signed-off-by: Ian Hoang <hoangia@amazon.com> * Revised README to better specify expand-data-corpus.py feature Signed-off-by: Ian Hoang <hoangia@amazon.com> --------- Signed-off-by: Ian Hoang <hoangia@amazon.com> Co-authored-by: Ian Hoang <hoangia@amazon.com> Signed-off-by: Govind Kamat <govkamat@amazon.com>
…pus.py beta feature (#92) (#93) * Update README.md to include additional information on expand-data-corpus.py beta feature (#92) Signed-off-by: Ian Hoang <hoangia@amazon.com> * Revised README to better specify expand-data-corpus.py feature Signed-off-by: Ian Hoang <hoangia@amazon.com> --------- Signed-off-by: Ian Hoang <hoangia@amazon.com> Co-authored-by: Ian Hoang <hoangia@amazon.com> Signed-off-by: Govind Kamat <govkamat@amazon.com>
Description
This PR quickly adds an extra sentence explaining what directory expand-data-corpus.py influences.
Issues Resolved
#92
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.