Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default pipeline to benchmark-only #387

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

cgchinmay
Copy link
Collaborator

Description

If no pipeline is specified then by default 'benchmark-only' will be used

Issues Resolved

#326

Testing

  • New functionality includes testing

[Describe how this change was tested]
Tested against already running cluster without specifying pipeline. default 'benchmark-only' will be used

python3 benchmark.py execute-test --workload=http_logs --target-hosts=https://localhost:9200 --distribution-version=2.10.0 --client-options="basic_auth_user:'admin',basic_auth_password:'admin',verify_certs:false,use_ssl:false" --test-mode --kill-running-processes

Output logs

2023-10-10 03:17:48,323 -not-actor-/PID:52566 osbenchmark.test_execution_orchestrator INFO Test Execution id [452bd58d-31ee-4da5-86ed-b77339cfb411]
2023-10-10 03:17:48,324 -not-actor-/PID:52566 osbenchmark.test_execution_orchestrator INFO User specified no pipeline. Using default pipeline [benchmark-only].

validated by running

make test

..

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================= 1186 passed, 5 skipped, 3 warnings in 6.43s ==================

Added new UT


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cgchinmay
Copy link
Collaborator Author

Will take a look at the failures and address them

Signed-off-by: Chinmay Gadgil <chinmay5j@gmail.com>
@cgchinmay
Copy link
Collaborator Author

Will take a look at the failures and address them

fixed failed integration test. ran make it locally and verified

Signed-off-by: Chinmay Gadgil <chinmay5j@gmail.com>
@IanHoang IanHoang merged commit 4ebcb28 into opensearch-project:main Oct 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants