Update force merge polling #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay and
rishabh6788
as code owners
VijayanB
force-pushed
the
update-force-merge-polling
branch
4 times, most recently
from
8880977
to
e17abfd
Compare
navneet1v
approved these changes
Mar 26, 2024
gkamat
requested changes
Apr 5, 2024
| request_context_holder.on_client_request_end() | ||
| complete = True | ||
| break | ||
| await asyncio.sleep(params.get("poll-period")) |
There was a problem hiding this comment.
What happens when a connection timeout is thrown if a long poll period is specified and control returns to the caller?
There was a problem hiding this comment.
Did you mean when connection timeout is thrown during get task api?
There was a problem hiding this comment.
Yes, admittedly a small possibility, but any exceptions raised by the client will get caught by the caller otherwise.
VijayanB
force-pushed
the
update-force-merge-polling
branch
from
e17abfd
to
81ef433
Compare
|
@gkamat can you take look at one more time. Thanks |
Change force merge polling logic to use wait_for_completion to false, to make it async and use task's get api to check whether task is completed or not to exit from force merge. Here, request end time is calcuated only after task is completed. This request end time will not be 100% accurate, since, we use polling to check whether task status is completed or not. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
update-force-merge-polling
branch
from
81ef433
to
f7eb800
Compare
gkamat
requested changes
Apr 17, 2024
IanHoang
reviewed
Apr 19, 2024
IanHoang
reviewed
Apr 19, 2024
IanHoang
requested changes
Apr 19, 2024
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
update-force-merge-polling
branch
from
9f46928
to
698a068
Compare
|
@IanHoang Updated PR with your feedback, Can you take a look one more time ? Thanks. |
IanHoang
approved these changes
Apr 19, 2024
|
@gkamat Can you take a look at this PR? This change is blocker for some of our runs that depends on large force merge time. |
gkamat
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change force merge polling logic to use wait_for_completion
to false, to make it async and use task's get api to check
whether task is completed or not to exit from force merge.
Here, request end time is calcuated only after task is completed.
This request end time will not be 100% accurate, since, we use polling to check
whether task status is completed or not.
Issues Resolved
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.