Added runners to register and deploy ml-model #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Model and DeployMlModel. Signed-off-by: Vesa Pehkonen <vesa.pehkonen@intel.com>
vpehkone
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay and
rishabh6788
as code owners
IanHoang
reviewed
Apr 3, 2024
IanHoang
reviewed
Apr 3, 2024
IanHoang
reviewed
Apr 3, 2024
IanHoang
reviewed
Apr 3, 2024
IanHoang
reviewed
Apr 3, 2024
IanHoang
requested changes
Apr 3, 2024
- added expection handling and logging for DeletePipeline runner - removed empty expection from DeleteMlModel and RegisterMlModel runners - added the "number-of-hits-to-return" variable Signed-off-by: Vesa Pehkonen <vesa.pehkonen@intel.com>
|
@IanHoang Can you please review, I have addressed the issues. |
Signed-off-by: Vesa Pehkonen <vesa.pehkonen@intel.com>
IanHoang
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added runners DeletePipeline, DeleteMlModel, RegisterMlModel and DeployMlModel. So that we can run the new workload semantic_search, that does indexing and search with vector embedding.
Issues Resolved
opensearch-project/opensearch-benchmark-workloads#198
Testing
Tested by executing the neural_search workload
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.