Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an error in DeleleMlModel runner. #537

Merged
merged 14 commits into from
Jul 1, 2024
Merged

Fixed an error in DeleleMlModel runner. #537

Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e6e3910
Added runners for the tasks DeletePipeline, DeleteMlModel, RegisterMl…
vpehkone Mar 29, 2024
1930e18
Merge remote-tracking branch 'origin/main' into neural_search
vpehkone Apr 5, 2024
b55857b
Addressed the following issues:
vpehkone Apr 5, 2024
4fa2752
Removed unused variable e.
vpehkone Apr 19, 2024
17082e9
Merge remote-tracking branch 'origin/main' into neural_search
vpehkone Apr 19, 2024
b89412f
Merge remote-tracking branch 'origin/main' into neural_search
vpehkone May 20, 2024
440f066
Fixed an error in DeleleMlModel runner. Before we delete a model, we …
vpehkone May 20, 2024
fe89f96
Simplified if-statement in DeleteMlModel runner.
vpehkone May 21, 2024
a5cc985
Fixed pylint R1714 in DeleteMlModel runner.
vpehkone May 21, 2024
d142661
Merge remote-tracking branch 'origin/main' into neural_search
vpehkone May 24, 2024
af8570a
Refactored the code in DeleteMlModel.
vpehkone May 24, 2024
58932e7
Changed time.sleep to asyncio.sleep in DeleteMlModel.
vpehkone May 24, 2024
b4f3d7b
Merge remote-tracking branch 'origin/main' into neural_search
vpehkone Jun 16, 2024
81e3ce8
Added a timeout for the undeploying ml-model in DeleteMlModel runner.
vpehkone Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions osbenchmark/worker_coordinator/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2400,6 +2400,11 @@ def __repr__(self, *args, **kwargs):
class DeleteMlModel(Runner):
@time_func
async def __call__(self, opensearch, params):
async def _is_deployed(model_id):
resp = await opensearch.transport.perform_request('GET', '_plugins/_ml/models/' + model_id)
state = resp.get('model_state')
return state in ('PARTIALLY_DEPLOYED', 'DEPLOYED')

body= {
"query": {
"match_phrase": {
Expand All @@ -2422,8 +2427,12 @@ async def __call__(self, opensearch, params):
model_ids.add(id)

for model_id in model_ids:
resp=await opensearch.transport.perform_request('POST', '/_plugins/_ml/models/' + model_id + '/_undeploy')
resp=await opensearch.transport.perform_request('DELETE', '/_plugins/_ml/models/' + model_id)
await opensearch.transport.perform_request('POST', '/_plugins/_ml/models/' + model_id + '/_undeploy')

for model_id in model_ids:
while await _is_deployed(model_id):
await asyncio.sleep(1)
vpehkone marked this conversation as resolved.
Show resolved Hide resolved
await opensearch.transport.perform_request('DELETE', '/_plugins/_ml/models/' + model_id)

def __repr__(self, *args, **kwargs):
return "delete-ml-model"
Expand Down
Loading