Adds --randomization-alpha flag controlling distribution of repeated queries #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
peteralfonsi
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
gkamat
approved these changes
Jun 27, 2024
osbenchmark/benchmark.py
Outdated
| test_execution_parser.add_argument( | ||
| "--randomization-alpha", | ||
| help=f"The alpha parameter used for the Zipf distribution for query randomization. Low values spread the distribution out, " | ||
| f"high values favor the most common queries more. " |
There was a problem hiding this comment.
nit: "more" is redundant. "high values favor the most common queries."
IanHoang
approved these changes
Jun 27, 2024
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
finnroblin
pushed a commit
to finnroblin/opensearch-benchmark
that referenced
this pull request
Jul 19, 2024
…queries (opensearch-project#564) Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#455 introduced a way to controllably randomize range queries in workloads, which is useful in testing caching behavior. One relevant parameter is Zipf alpha, which changes the shape of the Zipf distribution used for repeated queries. If alpha is small, queries will be more evenly distributed, while if it's large the few most common queries will be preferred more.
I intended to include this as a flag in my original PR but I apparently forgot to do this, and currently alpha is hardcoded to 1. This PR exposes
--randomization-alphaso the user can set this value explicitly.Issues Resolved
N/A
Testing
Manually tested in a debug version of this branch, by checking the value of the flag made it to QueryRandomizerWorkloadProcessor.zipf_alpha, and checking the indices generated for different values of alpha match what we would expect.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.