add default value for master-node when provisioning cluster using OSB #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
OVI3D0
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
gkamat
pushed a commit
to gkamat/opensearch-benchmark
that referenced
this pull request
Aug 22, 2024
…opensearch-project#621) Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
cgchinmay
reviewed
Aug 26, 2024
| f"The provided --node-name '{node_name}' and --master-nodes '{master_nodes}' are different. " | ||
| f"Using '{node_name}' for both node name and initial master node." | ||
| ) | ||
| master_nodes = [node_name] |
There was a problem hiding this comment.
I am wondering, If this is the desired behavior then do we want to expose master_nodes ? Here we are reporting error but override the master_nodes values and continue with provisioning. I think we should either fail so that user is notified or not expose the master_nodes field at all. @IanHoang would like to know your thoughts as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned by @gkamat, when provisioning a cluster in OSB, the master node specification should match the node name. This change ensures that these two values always match, by performing a check before building the cluster and ensuring the two values match before moving on.
Issues Resolved
#380
Testing
tested with
make test+make itand by provisioning clusters with mismatched values, as well as missing values for either node-name or master-node value.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.