Add tag as the release branch in jenkinsfile release #640
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
| 'cp -a opensearch-benchmark/* ./"', | ||
| 'cd docker/ci', | ||
| "su $(id -un 1000) -c \"cd docker/ci", | ||
| "git clone https://github.com/opensearch-project/opensearch-benchmark --branch ${tag} --single-branch opensearch-benchmark", |
There was a problem hiding this comment.
Our tags are with V.V.V format but our branches use V.V (do not have the patch version). Will this work with the current branch structure still?
There was a problem hiding this comment.
$tag is just a var holding $ref: https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/standardReleasePipelineWithGenericTrigger.groovy#L58C13-L58C16
$ref is holding the actual tag name: https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/standardReleasePipelineWithGenericTrigger.groovy#L42
And --branch accept branch name and tag name as so on despite the param name is --branch. It just pull the HEAD based on the branch or tag you provide:
https://git-scm.com/docs/git-clone#Documentation/git-clone.txt-code--branchcodeemltnamegtem
We should be good with this change.
$ git clone https://github.com/opensearch-project/opensearch-benchmark --branch 1.9.0 --single-branch opensearch-benchmark
Cloning into 'opensearch-benchmark'...
remote: Enumerating objects: 17252, done.
There was a problem hiding this comment.
Sounds good. Thanks for clarifying.
| 'cp -a opensearch-benchmark/* ./"', | ||
| 'cd docker/ci', | ||
| "su $(id -un 1000) -c \"cd docker/ci", | ||
| "git clone https://github.com/opensearch-project/opensearch-benchmark --branch ${tag} --single-branch opensearch-benchmark", |
There was a problem hiding this comment.
Sounds good. Thanks for clarifying.
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit cc1f62b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add tag as the release branch in jenkinsfile release
Issues Resolved
Closes #641
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.