Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows zip support for promotion artifacts #31

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Add windows zip support for promotion artifacts

Issues Resolved

opensearch-project/opensearch-build#2306

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added enhancement New feature or request windows labels Nov 9, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner November 9, 2022 00:44
@peterzhuamazon peterzhuamazon self-assigned this Nov 9, 2022
@peterzhuamazon
Copy link
Member Author

This will update the version to 1.2.0.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions and nitpicks. Thanks.

vars/promoteArtifacts.groovy Show resolved Hide resolved
vars/promoteArtifacts.groovy Outdated Show resolved Hide resolved
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #31 (9d4b5ee) into main (8c4a662) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #31   +/-   ##
=========================================
  Coverage     83.78%   83.78%           
  Complexity       24       24           
=========================================
  Files            62       62           
  Lines           185      185           
  Branches         10       10           
=========================================
  Hits            155      155           
  Misses           24       24           
  Partials          6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon peterzhuamazon merged commit acd16a6 into opensearch-project:main Nov 9, 2022
@peterzhuamazon peterzhuamazon deleted the win_lib_1 branch November 9, 2022 05:44
peterzhuamazon added a commit that referenced this pull request Nov 9, 2022
* Add windows zip support for promotion artifacts

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Update tests

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Update test cases

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon added a commit that referenced this pull request Nov 9, 2022
…mp to 1.2.0

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants