Pass in initial admin password in jenkins verification library #357
Conversation
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
peterzhuamazon,
prudhvigodithi,
gaiksaya and
rishabh6788
as code owners
|
Related to: opensearch-project/opensearch-build#4302 |
|
@peterzhuamazon @rishabh6788 @gaiksaya would this run into the same issue? Would < 2.12.0 versions of OpenSearch be built using this validation library and fail because the admin:admin changes are not consumed in those prior versions? |
| @@ -46,7 +46,7 @@ def call(Map args = [:]) { | |||
| //Install OpenSearch with designated version via yum | |||
| println("Start installation with yum.") | |||
| rpmCommands( | |||
| command: "install", | |||
| command: "sudo env OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123! install", | |||
There was a problem hiding this comment.
Are you expecting user to first define the env var before running yum/rpm install?
There was a problem hiding this comment.
You need to change the spec files of both deb and rpm, check if the var is set else exit with error msgs in the console.
There was a problem hiding this comment.
Addressed in build repo companion PR.
|
this should be unblocked by: opensearch-project/opensearch-build#4332 |
Signed-off-by: Derek Ho <dxho@amazon.com>
|
Addressed all comments. @peterzhuamazon can you take a look, pending the companion PR in the build repo? Thanks! |
|
@peterzhuamazon @prudhvigodithi is this PR even needed anymore? I am not sure how this library is being used, if at all during the build process. |
Description
Starting in 2.12.0, installing the security demo configuration requires an initial admin password to be passed in. This changes some validation library steps to expect this.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.